[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057

izarutskaya · 2023-09-23T07:23:18Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open Android App
Login with any account
Go to Settings > Wallet

Expected Result:

Settings > Wallet opens correctly

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 11.3.73-0

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6211288_Android-Crash-Wallet.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima /Applause-Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695364840745219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0139cc3c5c00612428
Upwork Job ID: 1705775981192208384
Last Price Increase: 2023-09-24
Automatic offers:

situchan | Reviewer | 26842492
pradeepmdk | Contributor | 26842494

melvin-bot · 2023-09-23T07:23:23Z

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-23T07:23:25Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

OSBotify · 2023-09-23T07:25:30Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-23T07:25:33Z

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

pradeepmdk · 2023-09-23T07:48:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when opening Settings > Wallet

What is the root cause of that problem?

App/src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

Line 351 in 5aa7f6d

App/src/pages/settings/Wallet/WalletPage/BaseWalletPage.js

Line 453 in 5aa7f6d

BaseWalletPage.displayName = BaseWalletPage;

https://reactnative.dev/docs/view#testid
displayName should be string
from this PR https://github.com/Expensify/App/pull/27978/files

What changes do you think we should make in order to solve the problem?

change to
BaseWalletPage.displayName = 'BaseWalletPage';

melvin-bot · 2023-09-24T02:47:42Z

Job added to Upwork: https://www.upwork.com/jobs/~0139cc3c5c00612428

melvin-bot · 2023-09-24T02:47:45Z

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-09-24T02:47:49Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

MitchExpensify · 2023-09-24T02:47:57Z

Reproduced

situchan · 2023-09-24T03:42:17Z

@pradeepmdk's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-09-24T03:42:21Z

Current assignee @amyevans is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

amyevans · 2023-09-24T14:02:11Z

@pradeepmdk this is a deploy blocker so ideally we can get the PR merged within the next ~12 hours. Let me know if that doesn't work for you and we can take it over internally. Thanks!

melvin-bot · 2023-09-24T14:02:26Z

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-09-24T14:02:29Z

📣 @pradeepmdk 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

pradeepmdk · 2023-09-24T14:03:44Z

@amyevans sure I will raise the pr in few hours

melvin-bot · 2023-09-25T09:30:06Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-09-25T09:30:09Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Android - App crashes when opening Settings > Wallet #28089

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@pradeepmdk requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)
@Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-25T09:30:11Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

MitchExpensify · 2023-09-26T04:37:08Z

Added a reminder to pay on the 2nd, please take a look at the BZ steps above when you get a chance @situchan

situchan · 2023-09-26T05:22:53Z

The PR that introduced the bug has been identified. Link to the PR: refactored BasePaymentsPage to function based component #22412
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22412/files#r1336638246
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was caught by Applause team so no need further regression test.

melvin-bot · 2023-09-28T18:33:48Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Android - App crashes when opening Settings > Wallet #28089

If no regressions arise, payment will be issued on 2023-10-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@pradeepmdk requires payment offer (Contributor)
@situchan requires payment offer (Reviewer)
@Natnael-Guchima requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-28T18:33:50Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

MitchExpensify · 2023-09-29T23:10:05Z

Payment Summary:

Reporting: $250 @Natnael-Guchima
C: $750 @pradeepmdk (Upwork)
C+: $750 @situchan (Upwork)

Natnael-Guchima · 2023-09-30T05:33:12Z

@MitchExpensify I haven't been paid for reporting bonus yet.

MitchExpensify · 2023-10-02T19:46:49Z

Updated @Natnael-Guchima, thanks!

MitchExpensify · 2023-10-02T19:48:08Z

Mind applying to the job here as a next step @Natnael-Guchima https://www.upwork.com/jobs/~0139cc3c5c00612428

Thanks

MitchExpensify · 2023-10-02T19:51:39Z

Paid @pradeepmdk & @situchan 👍

Waiting on @Natnael-Guchima and will close once paid

Natnael-Guchima · 2023-10-03T03:58:05Z

@MitchExpensify I have applied to the job. Thanks!

MitchExpensify · 2023-10-03T22:41:04Z

Offer sent! Thanks

Natnael-Guchima · 2023-10-04T04:38:11Z

Accepted the offer. Thanks

MitchExpensify · 2023-10-05T20:48:36Z

Paid, closing!

izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 23, 2023

melvin-bot bot assigned MitchExpensify Sep 23, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 23, 2023

OSBotify mentioned this issue Sep 23, 2023

Deploy Checklist: New Expensify 2023-09-22 #28013

Closed

96 tasks

melvin-bot bot assigned amyevans Sep 23, 2023

MitchExpensify added the External Added to denote the issue can be worked on by a contributor label Sep 24, 2023

melvin-bot bot changed the title ~~Android - App crashes when opening Settings > Wallet~~ [$500] Android - App crashes when opening Settings > Wallet Sep 24, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 24, 2023

melvin-bot bot assigned situchan Sep 24, 2023

amyevans assigned pradeepmdk Sep 24, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 24, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Sep 25, 2023

melvin-bot bot changed the title ~~[$500] Android - App crashes when opening Settings > Wallet~~ [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet Sep 25, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Sep 25, 2023

This was referenced Sep 26, 2023

Card Settings - Rename PaymentsPage to WalletPage #24632

Merged

refactored BasePaymentsPage to function based component #22412

Merged

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 28, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet~~ [HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet Sep 28, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 1, 2023

Pujan92 mentioned this issue Oct 4, 2023

[$500] Connect Bank account - Crash when completed adding BA manually #28811

Closed

6 tasks

MitchExpensify closed this as completed Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057

[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057

izarutskaya commented Sep 23, 2023 •

edited by kbecciv

Loading

melvin-bot bot commented Sep 23, 2023

melvin-bot bot commented Sep 23, 2023 •

edited by MitchExpensify

Loading

OSBotify commented Sep 23, 2023

melvin-bot bot commented Sep 23, 2023

pradeepmdk commented Sep 23, 2023 •

edited

Loading

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

MitchExpensify commented Sep 24, 2023

situchan commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

amyevans commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

pradeepmdk commented Sep 24, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

MitchExpensify commented Sep 26, 2023

situchan commented Sep 26, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023

MitchExpensify commented Sep 29, 2023 •

edited

Loading

Natnael-Guchima commented Sep 30, 2023

MitchExpensify commented Oct 2, 2023

MitchExpensify commented Oct 2, 2023

MitchExpensify commented Oct 2, 2023

Natnael-Guchima commented Oct 3, 2023

MitchExpensify commented Oct 3, 2023

Natnael-Guchima commented Oct 4, 2023 •

edited

Loading

MitchExpensify commented Oct 5, 2023

[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057

[HOLD for payment 2023-10-05] [HOLD for payment 2023-10-02] [$500] Android - App crashes when opening Settings > Wallet #28057

Comments

izarutskaya commented Sep 23, 2023 • edited by kbecciv Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 23, 2023

melvin-bot bot commented Sep 23, 2023 • edited by MitchExpensify Loading

Bug0 Triage Checklist (Main S/O)

OSBotify commented Sep 23, 2023

melvin-bot bot commented Sep 23, 2023

pradeepmdk commented Sep 23, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

MitchExpensify commented Sep 24, 2023

situchan commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

amyevans commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

melvin-bot bot commented Sep 24, 2023

pradeepmdk commented Sep 24, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

melvin-bot bot commented Sep 25, 2023

MitchExpensify commented Sep 26, 2023

situchan commented Sep 26, 2023

melvin-bot bot commented Sep 28, 2023

melvin-bot bot commented Sep 28, 2023

MitchExpensify commented Sep 29, 2023 • edited Loading

Natnael-Guchima commented Sep 30, 2023

MitchExpensify commented Oct 2, 2023

MitchExpensify commented Oct 2, 2023

MitchExpensify commented Oct 2, 2023

Natnael-Guchima commented Oct 3, 2023

MitchExpensify commented Oct 3, 2023

Natnael-Guchima commented Oct 4, 2023 • edited Loading

MitchExpensify commented Oct 5, 2023

izarutskaya commented Sep 23, 2023 •

edited by kbecciv

Loading

melvin-bot bot commented Sep 23, 2023 •

edited by MitchExpensify

Loading

pradeepmdk commented Sep 23, 2023 •

edited

Loading

MitchExpensify commented Sep 29, 2023 •

edited

Loading

Natnael-Guchima commented Oct 4, 2023 •

edited

Loading