[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on FAB icon and select Request money
2. Go to scan tab
3. Upload receipt and request money
4. Go to transaction thread
5. Click on image
6. Click on three dots and select replace
7. Try to drop image

Expected Result:

green drag and drop area should show in full screen same as scan tab

Actual Result:

drag and drop area does not cover full screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.73-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-20.at.4.46.48.PM.mov

Recording.4683.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210899596209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019a657764a62d532c
• Upwork Job ID: 1705215482777022464
• Last Price Increase: 2023-09-22
• Automatic offers:
• hoangzinh | Reviewer | 26876728
• gadhiyamanan | Contributor | 26876729
• gadhiyamanan | Reporter | 26876731

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

In EditRequestReceiptPage, we don't wrap the header into DragAndDropProvider the same as MoneyRequestSelectorPage. So the green drag and drop area does not show in full screen

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 39 in e52f21a

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

We should move HeaderWithBackButton into DragAndDropProvider

<DragAndDropProvider>
    <HeaderWithBackButton
        title={translate('common.receipt')}
        onBackButtonPress={Navigation.goBack}
    />

    <ReceiptSelector
        route={route}
        transactionID={transactionID}
    />
</DragAndDropProvider>

What alternative solutions did you explore? (Optional)

NA

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen in EditRequestReceiptPage.js but it shown in MoneyRequestSelectorPage.js

What is the root cause of that problem?

the root cause is the HeaderWithBackButton is not a child of DragAndDropProvider.

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 44 in 94c07ea

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector
	route={route}
	transactionID={transactionID}
	/>
	</DragAndDropProvider>

What changes do you think we should make in order to solve the problem?

we need to move HeaderWithBackButton inside DragAndDropProvider

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019a657764a62d532c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[gadhiyamanan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

HeaderWithBackButton is excluded from DragAndDropProvider here

What changes do you think we should make in order to solve the problem?

Add HeaderWithBackButton as child element of DragAndDropProvider in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 45 in a240941

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector
	route={route}
	transactionID={transactionID}
	/>
	</DragAndDropProvider>

What alternative solutions did you explore? (Optional)

N/A

[kbecciv]

Proposal by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695210899596209

Proposal

Please re-state the problem that we are trying to solve in this issue.

green drag and drop area does not show in full screen

What is the root cause of that problem?

HeaderWithBackButton is excluded from DragAndDropProvider here

What changes do you think we should make in order to solve the problem?

Add HeaderWithBackButton as child element of DragAndDropProvider in EditRequestReceiptPage.js

App/src/pages/EditRequestReceiptPage.js

Lines 36 to 45 in a240941

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector
	route={route}
	transactionID={transactionID}
	/>
	</DragAndDropProvider>

What alternative solutions did you explore? (Optional)

N/A

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Drag and drop highlighting when replacing the receipt from 3 dot menu is different from the drag and drop highlighting in request money scan page.

What is the root cause of that problem?

We are wrapping only the ReceiptSelector here with DragAndDropProvider

App/src/pages/EditRequestReceiptPage.js

Lines 35 to 44 in 9ab20c5

	<HeaderWithBackButton
	title={translate('common.receipt')}
	onBackButtonPress={Navigation.goBack}
	/>
	<DragAndDropProvider>
	<ReceiptSelector
	route={route}
	transactionID={transactionID}
	/>
	</DragAndDropProvider>

unlike here

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 88 to 93 in 9ab20c5

	<DragAndDropProvider
	isDisabled={props.selectedTab !== CONST.TAB.SCAN}
	setIsDraggingOver={setIsDraggingOver}
	>
	<View style={[styles.flex1, safeAreaPaddingBottomStyle]}>
	<HeaderWithBackButton

that wraps the header as well.

What changes do you think we should make in order to solve the problem?

We wrap the header as well like this in EditRequestReceiptPage

            <DragAndDropProvider>
                <HeaderWithBackButton
                    title={translate('common.receipt')}
                    onBackButtonPress={Navigation.goBack}
                />
                <ReceiptSelector
                    route={route}
                    transactionID={transactionID}
                />
            </DragAndDropProvider>

What alternative solutions did you explore? (Optional)

If we don't want the header highlighting for both cases we might wrap with DragAndDropProvider from only here in MoneyRequestSelectorPage

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 97 in 9ab20c5

{iouType === CONST.IOU.MONEY_REQUEST_TYPE.REQUEST ? (

excluding the HeaderWithBackButton

[hoangzinh]

Thanks for proposals, everyone. All of proposals have correct RCA and have the same approach. But because @gadhiyamanan is first, I think we should go with his proposal.

@gadhiyamanan's proposal #28014 (comment) looks good to me. I traced back the original PR #23046 of the Receipt tab but it doesn't describe how the Drop zone looks like. But in the recent related issue #25709, it seems we would like to make it cover the entire RHN screen. As such, we need to make the Drop zone cover the entire RHN screen in the Edit receipt page as well.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lschurr]

Bump @roryabraham - as long as we all agree, we just need to assign this one to @gadhiyamanan

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Green drag and drop area #28219

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Reviewer)
• @gadhiyamanan requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix desktop green drag and drop area #28579

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Reviewer)
• @gadhiyamanan requires payment offer (Contributor)
• @gadhiyamanan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment summary:

• Reporter: @gadhiyamanan $50 @dhairyasenjaliya $50
• Contributor: @gadhiyamanan $500
• Contributor+: @hoangzinh $500

[dhairyasenjaliya]

Hy @dylanexpensify im also eligible for reporting since after this pr issue still exists on desktop which i have reported here https://expensify.slack.com/archives/C049HHMV9SM/p1695970479763139?thread_ts=1695970479.763139&cid=C049HHMV9SM

[dylanexpensify]

updated @dhairyasenjaliya!

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Replace receipt #26508
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/26508/files#r1353623634
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A It's just a small UI improvement
• Determine if we should create a regression test for this bug: ❌ No, I think It's just a small UI improvement

[hoangzinh]

Quick bump @dylanexpensify on the payout

[dylanexpensify]

on it!

[dylanexpensify]

@dhairyasenjaliya please apply!

[dylanexpensify]

@hoangzinh @gadhiyamanan both of you have been paid!

[dhairyasenjaliya]

@dylanexpensify can you invite seems like currently I'm out of connects on Upwork at moment to apply :(

[dylanexpensify]

@dhairyasenjaliya done!

[dhairyasenjaliya]

thank you and accepted @dylanexpensify

[dylanexpensify]

offer sent @dhairyasenjaliya !

[dylanexpensify]

done!