[HOLD for payment 2023-10-05] [$500] [Distance] - distance request money next button becomes clickable for few seconds just before throughing route exceeds maximum limitation allowing to request 0 amount

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to + FAB
2. Click on request money and go to distance tab
3. Choose to destinations that are too far
4. Click on the next button quickly before it becomes disabled

Expected Result:

The next button doesn't become enabled

Actual Result:

The next button doesn't become enabled

Workaround:

The next button becomes enabled for few seconds allowing to request 0 amount

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

update.on.maximum.route.bug.1.mp4

Recording.4481.mp4

Expensify/Expensify Issue URL:
Issue reported by: @lidiyakelay
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694542534742739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01410a271d5db355bf
• Upwork Job ID: 1702411311659782144
• Last Price Increase: 2023-09-21
• Automatic offers:
• dukenv0307 | Contributor | 26808405
• lidiyakelay | Reporter | 26808406

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Distance] - distance request money next button becomes clickable for few seconds just before throwing route exceeds maximum limitation allowing to request 0 amount

What is the root cause of that problem?

1. In the current logic, we disable the Next button based on three criteria: the size of the waypoints, hasRouteError and isOffline

App/src/components/DistanceRequest.js

Line 269 in 67f9f77

isDisabled={_.size(validatedWaypoints) < 2 || hasRouteError || isOffline}

2. But when we select a new waypoint, the size of the waypoints calculates immediately in the FE and becomes 2, while the hasRouterError is set only when the API from BE (which takes some delay) returns an error and merges that error to Onyx. So the Next button becomes enabled for a short amount of time and users can click it

What changes do you think we should make in order to solve the problem?

1. When we add a new route to the waypoint, we already set isLoading to true to indicate the loading state from BE

App/src/libs/actions/Transaction.js

Lines 174 to 176 in 0df67e1

	value: {
	comment: {
	isLoading: true,

2. In src/components/DistanceRequest.js, We should make use of that by adding isLoading to the isDisable condition of the button, This will make sure that we only enable the button after BE returns all data( including the error message if any )

isDisabled={_.size(validatedWaypoints) < 2 || hasRouteError || isOffline || isLoadingRoute}

3. We could add isLoading prop to that button to improve user experience

isLoading={isLoadingRoute}

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01410a271d5db355bf

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kevinksullivan]

clarifying if we are prioritizing distance issues

https://expensify.slack.com/archives/C05DWUDHVK7/p1694790927900289

[mananjadhav]

@kevinksullivan I don't think I have access to the slack thread. Can you please confirm if we're prioritizing this now?

[ahmedGaber93]

@mananjadhav is this slack issue https://expensify.slack.com/archives/C049HHMV9SM/p1694543469783499 will list here?
I think it is a different root cause.

[mananjadhav]

@ahmedGaber93 I meant the slack link @kevinksullivan tagged in the previous comment.

[ahmedGaber93]

@mananjadhav yes, I know, I am talking about another point, Kateryna Becciv ask you here to list this slack bug in this GH issue.
I ask to add a proposal for both if it listed here.

[kevinksullivan]

Yes we are @mananjadhav

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mananjadhav]

@dukenv0307's proposal seems to work.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[luacmartins]

Agreed with the selected proposal

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[mananjadhav]

@kevinksullivan Is the payout done for @dukenv0307 @lidiyakelay ? If yes then we can close this one out.

[melvin-bot]

@mananjadhav, @luacmartins, @kevinksullivan, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Just waiting on payment

[luacmartins]

Bump for payment @kevinksullivan

[melvin-bot]

@mananjadhav, @luacmartins, @kevinksullivan, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Still waiting on payment

[luacmartins]

Still pending payment

[luacmartins]

Kevin is ooo until Monday. Gonna reassign a BZ member to process payment.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

Hi @jliexpensify! @kevinksullivan is ooo so I reassign this. Could you please assist with payment?

[jliexpensify]

Ok catching up - here's Kevin's Payment Summary

Previous Upworks job is closed, so will make a new one

[jliexpensify]

New job post - https://www.upwork.com/jobs/~01da5d189add9def8a

Have invited @lidiyakelay ($50) and @dukenv0307 ($750)

[jliexpensify]

@dukenv0307 please accept so I can pay and close the job, cheers!

[dukenv0307]

@dukenv0307 please accept so I can pay and close the job, cheers!

@jliexpensify accepted, thank you!

[jliexpensify]

Job closed, everyone paid.

@mananjadhav here's Kevin's payment summary for your payment.