Payment DUE[$500] Profile - Inconsistent validation error message for required field in home address

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to personal details
2. Click in home address
3. Address line 1 is required field, when user goes from line 1 to address line2 without entering anything , error is shown
4. Click on country, a drop down is shown
5. Don’t select any country and come back
6. Enter state and city and zip code and click save
7. Only on clicking save , it shows country is required field

Expected Result:

When country is not selected from drop down it should show validation error

Actual Result:

Not showing until save is clicked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.68-12

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1694135684.MP4

Screen_Recording_20230912_183232_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Premsjce

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694136012916349

View all open jobs on GitHub
Inconsistent validation error message for required field in home address

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012751697148f06172
• Upwork Job ID: 1701622320141500416
• Last Price Increase: 2023-10-03
• Automatic offers:
• situchan | Reviewer | 0
• DylanDylann | Contributor | 0

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012751697148f06172

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @tjferriss (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[saraelsa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is an inconsistency in behavior between two required fields:

• If the user blurs address line 1, a validation message is immediately displayed.
• If the user closes the country selection menu, a validation message is not immediately displayed, and is only displayed once the form is submitted.

What is the root cause of that problem?

The Form component attaches certain event listeners to form elements, including onInputChange and onBlur. Depending on the configuration, validation is run for a field when the onBlur event fires.

The CountryPicker component exposes an onInputChange prop that is used by the Form component which is how it is able to pick up its value. However, it does not expose a similar onBlur prop that the Form component might use.

What changes do you think we should make in order to solve the problem?

Create a new property, onBlur, in CountryPicker. The hidePickerModal method will fire onBlur.

What alternative solutions did you explore? (Optional)

In addition to adding the onBlur property, update the Form component to not issue validation errors for empty fields on input. They will be validated on submission.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Yrds]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two inconsistencies related to validation triggers on Home address Form:

• Address line 1 text input required field error is shown as soon the user blur on field.
• Country picker is not being validated as the user closes picker, and only shows validation when user click on submit button.

What is the root cause of that problem?

Address Line 1

• The Address Line 1 validations is showing up on input blur because the AddressSearch component triggers props.onBlur which is calling validate function on Form component(validate method is called on every onBlur event).

Country picker

• CountryPicker component doesn't have any trigger when user closes it(when hidePickerModal is called), so there's nothing to perform a validation this moment.

What changes do you think we should make in order to solve the problem?

• As Form component is used in multiple pages, the AddressSearch component need to be modified to conditionally NOT call onBlur.
• CountryPicker needs to trigger onInputChange in order to call proper validation method when user closes modal.

What alternative solutions did you explore? (Optional)

No alternative solutions was explored.

[melvin-bot]

📣 @Yrds! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Yrds]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01fe692a84ada2b658

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[redpanda-bit]

I think calling the onBlur prop within CountryPicker#hidePickerModal is the right approach.

@Yrds

What changes do you think we should make in order to solve the problem?

• As Form component is used in multiple pages, the AddressSearch component need to be modified to conditionally NOT call onBlur.

We want to show the error on input blur so probably would want to keep it as it is now.

• CountryPicker needs to trigger onInputChange in order to call proper validation method when user closes modal.

I tried this solution while doing my analysis but using onBlur already calls the proper validation method.

[Yrds]

Yes, I think you are right. Also, calling onBlur seems to be the default behavior of other Form components on the application.

@redpanda-bit

[zanyrenney]

@situchan what are your thoughts on the above please?

[tjferriss]

@zanyrenney it looks like MelvinBot assigned us both. I'm going to unassign myself.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

weird, okay no worries @tjferriss

[situchan]

Ah forgot that hold was lifted. reviewing latest proposals

[thienlnam]

@situchan Bump again here

[situchan]

@DylanDylann can you please share test branch?

[DylanDylann]

@situchan Here is the test branch #35326

[DylanDylann]

@situchan Do you have any feedback about this one?

[zanyrenney]

bump @situchan

[situchan]

Ah this was missing in my list. Maybe because of weekly

[DylanDylann]

@situchan Any update here?

[situchan]

Thanks for the bump. I will update in an hr

[situchan]

@DylanDylann's proposal looks good to me

[DylanDylann]

@thienlnam Please help to review when you have a chance. Thanks

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

Will open PR today

[DylanDylann]

@situchan PR #35326 is ready to review

[situchan]

PR was deployed to production on Feb 28

[DylanDylann]

@zanyrenney Please help to process the next step

[zanyrenney]

payment summary

paid $500 @situchan
paid $500 @DylanDylann