[HOLD for payment 2023-09-27] [$500] Android - Emoji search box isn't autofocused

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open any chat report
2. Click on emoji symbol
3. Notice that the search box isn't in focus.

Expected Result:

Emoji search field should be autofocused

Actual Result:

Emoji search box isn't autofocused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.66.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2023-09-04-21-44-16.mp4

Screen_Recording_20230908_131654_New.Expensify.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693843563361019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142e9d617cdfc3cba
• Upwork Job ID: 1700199497560686592
• Last Price Increase: 2023-09-08
• Automatic offers:
• s-alves10 | Contributor | 26650249
• ashimsharma10 | Reporter | 26650253

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142e9d617cdfc3cba

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @sonialiap (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[ginsuma]

I think this is intentional.

[ashimsharma10]

@ginsuma it happens only in android and mweb Android. Not in other platforms ( haven't checked on iOS) tho. And is inconsistent

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji search input isn't auto focused in android native

What is the root cause of that problem?

As you can see below, we focus search input on modalShow event

App/src/components/EmojiPicker/EmojiPicker.js

Line 145 in 6e106c6

onModalShow={focusEmojiSearchInput}

In focusEmojiSearchInput function, emojiSearchInput is a ref of search input

But as you can see, we don't pass forwarded ref to TextInput in EmojiPickerMenu native.

App/src/components/EmojiPicker/EmojiPickerMenu/index.native.js

Lines 166 to 171 in 6e106c6

	<TextInput
	label={translate('common.search')}
	accessibilityLabel={translate('common.search')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
	onChangeText={filterEmojis}
	/>

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to pass forwarded ref to TextInput component.
In EmojiPickerMenu, update the code as below(and make sure to add forwardedRef to the props destructuring)

        <TextInput
            label={translate('common.search')}
            accessibilityLabel={translate('common.search')}
            accessibilityRole={CONST.ACCESSIBILITY_ROLE.TEXT}
            onChangeText={filterEmojis}
            ref={forwardedRef}
        />

This works as expected

Result

27047.mp4

What alternative solutions did you explore? (Optional)

[narefyev91]

Proposal from @s-alves10 looks good to me #27047 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[zanyrenney]

Not sure why it duped the assignment for Bug manager, removing SOnia!

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @ashimsharma10 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[zanyrenney]

Thanks @s-alves10 and @narefyev91 for the review!

[melvin-bot]

🎯 ⚡️ Woah @narefyev91 / @s-alves10, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @s-alves10 got assigned: 2023-09-13 10:02:21 Z
• when the PR got merged: 2023-09-15 02:36:53 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: auto focus on EmojiPicker search input #27340

If no regressions arise, payment will be issued on 2023-09-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @narefyev91 does not require payment (Contractor)
• @s-alves10 requires payment offer (Contributor)
• @ashimsharma10 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

@ginsuma it happens only in android and mweb Android. Not in other platforms ( haven't checked on iOS) tho. And is inconsistent

Yeah this was intentional. We should have kept this behavior for native mobile and mWeb as losing ~40% of the keyboard is incredibly annoying if you're just trying to select a common emoji.

[zanyrenney]

hey @s-alves10 please accept the offer for payout.

[zanyrenney]

Payments summary

@narefyev91 does not require payment (Contractor) - N/A
@s-alves10 requires payment offer (Contributor) - PAID $500 + $250 Urgency Bonus.
@ashimsharma10 requires payment offer (Reporter) - PAID $50.

[s-alves10]

Offer accepted

[zanyrenney]

All participants who can be paid through Upwork have been. @narefyev91 please request your payment via ND. CLosing!

[s-alves10]

@zanyrenney

This issue was merged in 3 days. I think this is eligible for speed bonus

cc @narefyev91

[s-alves10]

@zanyrenney

Can you check #27047 (comment)?