Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Improve AdHoc build time #26152

Closed
Julesssss opened this issue Aug 29, 2023 · 16 comments
Closed

[$500] Improve AdHoc build time #26152

Julesssss opened this issue Aug 29, 2023 · 16 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Aug 29, 2023

Problem

AdHoc builds are working well, but the build times are slow and other minor improvements can be made.

Solution

Implement further improvements:

  • We can shorten Android dev build time by adding one additional line in build.gradle where we will pass the flavors that are only for development and we can skip bundling JS and assets
  • Fabric requires iOS build schemes without spaces e.g. instead New Expensify AdHoc we should rename it to NewExpensifyAdHoc
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016b1f5eb0cd53791a
  • Upwork Job ID: 1696431313907130368
  • Last Price Increase: 2023-09-21
@Julesssss Julesssss added Engineering Weekly KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016b1f5eb0cd53791a

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

@Julesssss
Copy link
Contributor Author

Just noting that last time our prod release CI flows broke due to the name change as the build path changed. So we'll need to be careful to watch out for this when first releasing the changes.

@kowczarz
Copy link
Contributor

Hello! I'm Kamil from Software Mansion and I would like to work on this task.

@Julesssss Julesssss mentioned this issue Aug 29, 2023
57 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Aug 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

Triggered auto assignment to @tylerkaraszewski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Julesssss Julesssss reopened this Sep 21, 2023
@Julesssss Julesssss added NewFeature Something to build that is a new item. External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. and removed NewFeature Something to build that is a new item. Improvement Item broken or needs improvement. labels Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Current assignee @miljakljajic is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Improve AdHoc build time [$500] Improve AdHoc build time Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Current assignee @miljakljajic is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 21, 2023

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

@Julesssss
Copy link
Contributor Author

Hey @miljakljajic, can you pay out a C+ reviewer bonus for @sobitneupane please

@miljakljajic
Copy link
Contributor

Sent contract @sobitneupane !

@sobitneupane
Copy link
Contributor

@miljakljajic I will request payment in newDot. I believe a payment summary for the issue is all that's required.

@miljakljajic
Copy link
Contributor

Payment summary: 500 USD for the improvements made to AdHoc build time

@sobitneupane
Copy link
Contributor

Requested payment on newDot.

#26152 (comment)

@JmillsExpensify
Copy link

$500 payment approved for @sobitneupane based on BZ summary.

@miljakljajic
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants