[HOLD for payment 2024-02-14] [HOLD #24918][TS migration] Migrate 'IOU.js' lib to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/libs/actions/IOU.js	23

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[roryabraham]

Excited for this one – I think it will be particularly valuable. When can we expect a PR?

[VickyStash]

@roryabraham For now, this one is blocked by ReportUtils and Policy.js migrations. I'll prioritize it as soon as it gets unblocked!

[roryabraham]

HOLDing for #24918

[roryabraham]

Still on HOLD

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS migration] Migrate 'IOU.js' lib to TypeScript #34092

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@VickyStash] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[aimane-chnaif]

Please assign me here

[garrettmknight]

@aimane-chnaif offer out.

[aimane-chnaif]

Thanks. I know this is exception but just wanted to discuss amount based on the scale of PR, though TS migration.
It was large with IOU.js which had almost 4k lines of code. (Also #34092 (review))
And as seen in Tests step of PR, it involved full regression test of money request flow.
So can the bounty be increased?
cc: @roryabraham

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[garrettmknight]

Reassigning for payment. Should be a quick one once we decide!

[mallenexpensify]

@roryabraham 👀 please on the above.

I'm brand new here as BZ so I don't want to jump in without much context.

[garrettmknight]

Taking this one back over - @roryabraham can you comment on the complexity of this one?

[garrettmknight]

@roryabraham mind chiming in?

[roryabraham]

Yeah, I think it's fair to bump this one up to $750 due to the high volume of testing that had to happen. Saying that because it's probably 3x a "standard" TS migration issue

[garrettmknight]

Cool, all paid up. Closing!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.