[HOLD for payment 2023-08-28] [HOLD for payment 2023-08-24] LNH - The conversation will be removed from the LHN if the last message is an attachment

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #24466

Action Performed:

1. Open New Expensify app or https://staging.new.expensify.com/
2. Navigate to any conversation
3. Click the action menu in the conversation
4. Click on "Add attachment"
5. Add any valid attachment
6. Navigate to another conversation with another user

Expected Result:

A conversation should not disappear from the LNH menu, even if the last message was an attachment

Actual Result:

If the last message in a conversation is an attachment, that conversation disappears from the LNH menu when you switch to another conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.54.8

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6165898_Recording__26__2_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @namhihi237

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692015600197289

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[namhihi237]

I think I had reported here

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - The conversation is be removed from the LHN if the last message is an attachment.

What is the root cause of that problem?

In ReportUtils, we check if chat is empty by checking the key lastMessageText for the object returned by function getLastVisibleMessage.

App/src/libs/ReportUtils.js

Lines 2505 to 2510 in 2e8e699

	const isEmptyChat = !ReportActionsUtils.getLastVisibleMessage(report.reportID).lastMessageText;
	// Hide only chat threads that haven't been commented on (other threads are actionable)
	if (isChatThread(report) && isEmptyChat) {
	return false;
	}

But in getLastVisibleMessage, we return a different key lastMessageTranslationKey for attachments -

App/src/libs/ReportActionsUtils.js

Lines 403 to 411 in 58d7ac8

	function getLastVisibleMessage(reportID, actionsToMerge = {}) {
	const lastVisibleAction = getLastVisibleAction(reportID, actionsToMerge);
	const message = lodashGet(lastVisibleAction, ['message', 0], {});
	if (isReportMessageAttachment(message)) {
	return {
	lastMessageTranslationKey: CONST.TRANSLATION_KEYS.ATTACHMENT,
	};
	}

What changes do you think we should make in order to solve the problem?

We should check for both keys in shouldReportBeInOptionList while evaluating isEmptyChat -

const lastVisibleMessage = ReportActionsUtils.getLastVisibleMessage(report.reportID);
const isEmptyChat = !lastVisibleMessage.lastMessageText && !lastVisibleMessage.lastMessageTranslationKey;

What alternative solutions did you explore? (Optional)

NA

[Nikhil-Vats]

Hey @luacmartins @mountiny, this is a regression from #19321. I have found the root cause and tested that it is working. I can open a PR within right now if you agree.

[PauloGasparSv]

@Nikhil-Vats's proposal looks good to me!

[Nikhil-Vats]

@PauloGasparSv can I create a PR then?

[PauloGasparSv]

@PauloGasparSv can I create a PR then?

Let's just wait on @johnmlee101 too since they got assigned here : )

[mountiny]

@PauloGasparSv I dont think we have to wait for John for deploy blockers, as author of the original PR you have the best context, @Nikhil-Vats I think you can raise the PR with urgency as this is a deploy blcoker 🚀 thanks!

[PauloGasparSv]

@PauloGasparSv I dont think we have to wait for John for deploy blockers, as author of the original PR you have the best context, @Nikhil-Vats I think you can raise the PR with urgency as this is a deploy blcoker 🚀 thanks!

Will keep this in mind for next time!!!

Sorry for the delay then @Nikhil-Vats

[mountiny]

No worries, with deploy blockers its better to act as fast as possible 🚤

[Nikhil-Vats]

On it.

[Nikhil-Vats]

PR is ready for review.

[johnmlee101]

Assigning bug so we have a bug-zero member to handle the issue management!

[abdulrahuman5196]

Just to note @zanyrenney #24593 (comment)

[melvin-bot]

@johnmlee101, @Nikhil-Vats, @zanyrenney Eep! 4 days overdue now. Issues have feelings too...

[zanyrenney]

Hm @johnmlee101 where is the upwork job? I don't know what you mean by this comment:

Assigning bug so we have a bug-zero member to handle the issue management!

[abdulrahuman5196]

@zanyrenney This was a deployment blocker bug. Upwork link was not created(Not sure why)

Assigning bug so we have a bug-zero member to handle the issue management!

AFAIK, This was meant to close the payments on this issue.

[johnmlee101]

Correct, we'll need to manage payments for this, which I don't have control over

[zanyrenney]

job is here - can't find the upwork profiles for the c and c+,, please instead apply to the job @Nikhil-Vats @abdulrahuman5196

also the price is wrong and upwork isn't letting me change it.

The payment summary is:

Reporting bonus - $250 @namhihi237
Contributor payment $1000 [@Nikhil-Vats] + $500 urgency bonus
contributor plus payment $1000 [@abdulrahuman5196] + $500 urgency bonus

[zanyrenney]

I will pay the $1000 to each via upwork manually.

[Nikhil-Vats]

@zanyrenney There is also urgency bonus for this. Also, can you please add the upwork job link? I can't find it.

[namhihi237]

@zanyrenney Hello I am reporter, why I can not payment for issue?

[zanyrenney]

hey @namhihi237 sorry i thought it said reported by internal team - Applause.

[zanyrenney]

https://www.upwork.com/jobs/~0162ff834c53cf26b5

[namhihi237]

@zanyrenney I reported before on slack as you can see the reporter has my name above. @mountiny Can you confirm?

[zanyrenney]

Yep it's fine, I can see that, i've updated it. can you share your upwork profile? i can't find you in previous hires.

[namhihi237]

Thanks @zanyrenney https://www.upwork.com/freelancers/~01a15b20f90b6a1737

[zanyrenney]

@abdulrahuman5196 - invited to job
@Nikhil-Vats - offer sent
@namhihi237 - invited to job

[namhihi237]

I just submitted the job.

[zanyrenney]

payment summary
Reporting bonus - $250 @namhihi237 [PAID]
Contributor payment $1000 [@Nikhil-Vats] + $500 urgency bonus [PAID]
contributor plus payment $1000 [@abdulrahuman5196] + $500 urgency bonus [PAID]

[abdulrahuman5196]

@zanyrenney yes that's me

[zanyrenney]

Thanks! please accept the job so I can payout.

[zanyrenney]

All paid, see payment summary above: #24593 (comment)

[zanyrenney]

Closing!