[HOLD for payment 2023-08-08] [$1000] Dev: Web - Can't click plus button after leaving a room

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login with any account.
2. Create a new room.
3. Leave the room.
4. Click on plus button

Expected Result:

User can click plus button and it works as expected (show the context menu).

Actual Result:

User can't click plus button after leaving a room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.47-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-30.at.09.03.39.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690682725357069

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017df576fd65e43186
• Upwork Job ID: 1686101709086126080
• Last Price Increase: 2023-07-31

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

this is a regression from: #23528
the NoDropZone component, has a full screen width and prevents any events from passing to the LHN.

it will be rendered together based on the routes here:

App/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js

Line 34 in eb02006

{_.map(props.state.routes, (route, i) => {

When we click leave room and navigate to concierge the navigation route will be present, it will just push another new page without removing the Right modal navigator. hence the descriptor will be rendered inside NoDropZone

What changes do you think we should make in order to solve the problem?

To ensure that the NoDropZone component is not rendered when navigating to concierge, we should close the Right Modal Navigator before leaving. This is because the NoDropZone component only exists within the routes of the Right Modal Navigator. for example: we can just use Navigation.goBack just before leaveRoom.

What alternative solutions did you explore? (Optional)

Change the place where we add NoDropZone wrapper, to put it another suitable place.

[b4s36t4]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev: Web - Can't click plus button after leaving a room

What is the root cause of that problem?

I think this is the regression coming from this PR -> #23528.

It also happens for threads as well, if we leave a thread we can't click anything on LHN menu.

Here we have implemented NoDrop component for RHN, but due the fact we're navigating inside the RHN when deleting a Thread/Room we're just navigating to the CONCIERGE screen here

App/src/libs/actions/Report.js

Line 1247 in 24ed1be

function navigateToConciergeChat() {

and here as well

App/src/pages/ReportDetailsPage.js

Line 121 in 513fed9

action: () => Report.leaveRoom(props.report.reportID),

.

If we observe the Navigation state we're still having the RHN in the navigation state even though we've been out of the RHN screens and the code here rendering NoDropZone

App/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js

Line 55 in 24ed1be

if (route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {

component to the RHN assuming it's still no closed.

What changes do you think we should make in order to solve the problem?

I feel if it's the last screen in RHN we should remove the navigation state from RHN.
For this current issue we can update the function here

App/src/libs/actions/Report.js

Line 1247 in 24ed1be

function navigateToConciergeChat() {

to dismiss the modal before navigating any further to CONCIERGE report.

What alternative solutions did you explore? (Optional)

NA

[allroundexperts]

We have a PR for this ready for review.

[Beamanator]

I couldn't reproduce this exact issue, so closing

[getusha]

@Beamanator it's reproducible on main only.

[hungvu193]

@Beamanator Still able to reproduce on latest main

[Beamanator]

Good call y'all, sorry i got too excited to close this out

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Def reproducible in main :D

[hungvu193]

Thank you @joekaufmanexpensify , I've just accepted:smile:

[gadhiyamanan]

@joekaufmanexpensify i think this is not eligible for reporting bonus as this issue has same rca with #23885 and othe issue was reported first in slack

[joekaufmanexpensify]

@Beamanator @allroundexperts It does look to me the PR here would probably fix the other issue too (which was reported first), but curious if y'all agree?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.48-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add no dropzone only if RHN is active #23856

If no regressions arise, payment will be issued on 2023-08-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR: Migrate DragNDrop #23589
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23589/files#r1290992254
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@Beamanator] Determine if we should create a regression test for this bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[Beamanator]

Assigning @allroundexperts since they completed this job 👍 (no C+ reviewer)

[joekaufmanexpensify]

@Beamanator / @allroundexperts mind completing your portion of the BZ checklist here when you have a sec?

[Beamanator]

@allroundexperts mind taking care of the checklist here? 🙏

[allroundexperts]

On it now!

[allroundexperts]

Checklist

1. Migrate DragNDrop #23589
2. https://github.com/Expensify/App/pull/23589/files#r1290992254
   3 & 4. This was a regression from a PR that I had reviewed and was caught on dev environment (almost immediately after merging). The code did not even hit staging. As such, I don't think that a slack discussion or a regression test is needed here.

[allroundexperts]

@Beamanator @allroundexperts It does look to me the PR here would probably fix the other issue too (which was reported first), but curious if y'all agree?

That's correct @joekaufmanexpensify!

[joekaufmanexpensify]

Thanks! BZ checklist is complete.

[joekaufmanexpensify]

Okay, we chatted about this internally, and for fairness purposes, we decided @gadhiyamanan should actually receive the reporting bonus here, since they reported a bug with the same root cause, prior to this one being reported.

With that in mind, I'm going to send @gadhiyamanan a $250 reporting bonus offer here.

@hungvu193 I'm going to close your Upwork job, and request a $250 escrow refund for the job (since the $250 won't be paid out). We appreciate you reporting the bug in this issue! But paying out the first reporter for the bug's root cause is the best path forward to ensure a fair standard for how we handle bug reports.

Let me know if anyone has any questions!

[hungvu193]

Okay, we chatted about this internally, and for fairness purposes, we decided @gadhiyamanan should actually receive the reporting bonus here, since they reported a bug with the same root cause, prior to this one being reported.

With that in mind, I'm going to send @gadhiyamanan a $250 reporting bonus offer here.

@hungvu193 I'm going to close your Upwork job, and request a $250 escrow refund for the job (since the $250 won't be paid out). We appreciate you reporting the bug in this issue! But paying out the first reporter for the bug's root cause is the best path forward to ensure a fair standard for how we handle bug reports.

Let me know if anyone has any questions!

Thanks for explaining Joe. Please request a refund 😄

[joekaufmanexpensify]

Of course!

[joekaufmanexpensify]

@gadhiyamanan offer sent for $250!

[gadhiyamanan]

@joekaufmanexpensify offer accepted, thanks

[joekaufmanexpensify]

@hungvu193 contract ended with no payment!

[joekaufmanexpensify]

@gadhiyamanan $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Reporting was the only payment needed here. So this is now all set. Thanks everyone!