[HOLD for payment 2023-08-16] [$1000] Tooltip show email instead of display name when hover in remaining users avatar in a group

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to any account
2. Create a group chat of more than 4 people.
3. Hover on the remaining users avatar in LHN or Report header of a chat group

Expected Result:

The tooltip should display name of remaining users. Because we're showing the display name in the header already. It's inconsistency and hard for user to map emails in tooltip and display names in header

Actual Result:

The tooltip is showing emails of remaining users.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.5553.mp4

Screen.Recording.2023-07-17.at.22.23.03.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689607619109389

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01957373b884cf9d96
• Upwork Job ID: 1683585334338797568
• Last Price Increase: 2023-07-24
• Automatic offers:
• situchan | Reviewer | 25906124
• hoangzinh | Contributor | 25906128
• hoangzinh | Reporter | 25906134

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tooltip show email instead of display name when hover in remaining users avatar in a group

What is the root cause of that problem?

The old tooltip text is getting from the props.icon.name

App/src/components/MultipleAvatars.js

Line 79 in 7770b86

const tooltipTexts = props.shouldShowTooltip ? _.pluck(props.icons, 'name') : [''];

And when we get the icon.name of an chat group, we're preferring the login email over the displayName

App/src/libs/ReportUtils.js

Line 754 in 7770b86

lodashGet(personalDetails, [accountID, 'login'], lodashGet(personalDetails, [accountID, 'displayName'], '')),

What changes do you think we should make in order to solve the problem?

I think we need to change the order of getting here so that we get the displayName first, then get login email as a fallback

App/src/libs/ReportUtils.js

Line 754 in 7770b86

lodashGet(personalDetails, [accountID, 'login'], lodashGet(personalDetails, [accountID, 'displayName'], '')),

[Nikhil-Vats]

@puneetlath what's the expected behaviour here?

IMO, we do see the names in the header and when we hover the names in the header, we see the mapping of names to emails. So, I think it's fine but the new tooltip looks so much better than the old one that it'd be nice if we show something like it for the remaining users (+2 icon).

[puneetlath]

Hmm, interesting. I guess showing display names instead of emails would make sense in this scenario.

[slafortune]

Yep, I think the display name would be more informative than the email at times and look cleaner.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01957373b884cf9d96

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[priyankrawat]

Proposal
Please re-state the problem that we are trying to solve in this issue.
The tooltip shows email instead of display name when hovering in the remaining users avatar in a group

What is the root cause of that problem?
The code is fetching the participant's login i.e. the email and avatar URL from the personalDetails object, but it didn't include any logic to fetch the participant's first name or display name.

What changes do you think we should make in order to solve the problem?
Modifying the participantsList loop to fetch the participant's first name along with their login and avatar URL from the personalDetails object should solve the issue.

In ReportUtil.js file, we need to make this changes in Line 797-798:

lodashGet(personalDetails, [accountID, 'firstName'], lodashGet(personalDetails, [accountID, 'displayName'], '')), lodashGet(personalDetails, [accountID, 'login'], ''),

tooltip.copy.mov

The first four emails have profile names that are being displayed and the rest of the profiles don't have a name, so their email addresses are shown.

[melvin-bot]

📣 @priyankrawat! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Nikhil-Vats]

Hey @priyankrawat, you should put all of your proposed changes in your proposal in a single comment. This makes it easier for the C+ and the engineers to review.

[priyankrawat]

@Nikhil-Vats ok

[slafortune]

@situchan have you had a chance to review this?

[situchan]

@hoangzinh's proposal looks good to me.
I think we should use || operator instead of lodashGet fallback for safety in case displayName is empty string ('').
@hoangzinh please comment here to get assigned.
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

@situchan Thanks for giving me the suggestion. I will update it in the PR.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[techievivek]

Not overdue, I just assigned the issue to @hoangzinh

[hoangzinh]

@situchan @techievivek Thanks for accepting my proposal. The PR is ready #24094. Please help me review it. Thanks

[melvin-bot]

🎯 ⚡️ Woah @situchan / @hoangzinh, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @hoangzinh got assigned: 2023-08-02 15:04:51 Z
• when the PR got merged: 2023-08-07 04:34:29 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Tooltip show email instead of display name when hover in remaining users avatar in a group #24094

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

External issue reporter - @hoangzinh - $250 - PD
Contributor that fixed the issue - @hoangzinh $1500 - PD
Contributor+ that helped on the issue and/or PR - @situchan $1500 - PD

Speed bonus given 🎉
when @hoangzinh got assigned: 2023-08-02 15:04:51 Z
when the PR got merged: 2023-08-07 04:34:29 UTC

[slafortune]

@situchan can you complete the checklist, please?

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: N/A. This was not bug but inconsistency.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - REGRESSION TEST GH

Regression Test Proposal

1. Create a group chat of more than 4 people (I.e, userA and userB already set first/last name, userC and user D hasn't set first/last name yet)
2. Hover on the remaining users avatar in LHN or Report header of a chat group
3. Verify that tooltip shows display name of user A and user B
4. Verify that tooltip shows login email of user C and user D