[HOLD for payment 2023-08-10] [$2000] 'Date' section is not grayed out and the cursor does not change on the IOU report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Request Money from any user
2. Go to the IOU report
   Notice that the Amount and Description are grayed out But not the 'Date' section. And the cursor does not change.

Expected Result:

The 'Date' section is grayed out and the cursor changes

Actual Result:

The 'Date' section is not grayed out and the cursor does not change on the IOU report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.39.5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Test71_Notgrayedout-1.mp4

Recording.3567.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689115720723609

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184afd377a2246d04
• Upwork Job ID: 1684480022772416512
2023-07-31
• Automatic offers:
• aimane-chnaif | Reviewer | 25857860
• c3024 | Contributor | 25857863
• daveSeife | Reporter | 25857866

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Date in money request report is not greyed out

What is the root cause of that problem?

In amount and description we have disabled={isSettled} but it is missing in the date in MoneyRequestView page
Date field does not have disabled = {isSettled}

<MenuItemWithTopDescription
                description={translate('common.date')}
                title={formattedTransactionDate}
                // shouldShowRightIcon={!isSettled}
                // onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
            />

What changes do you think we should make in order to solve the problem?

We should add disabled = {isSettled} for that.

<MenuItemWithTopDescription
                description={translate('common.date')}
                title={formattedTransactionDate}
                disabled={isSettled}
                // shouldShowRightIcon={!isSettled}
                // onPress={() => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.DATE))}
            />

We can do the same in MoneyRequestDetails as well just in case.

What alternative solutions did you explore? (Optional)

[Julesssss]

Definitely not a blocker. Checking it off the list.

[Julesssss]

Odd, I'm not able to reproduce on production (web). I can see here that @kbecciv was able to though 😕

[aimane-chnaif]

@Julesssss can we tackle this in #22642? We're touching same component.

[Julesssss]

@aimane-chnaif sure. It's no longer a blocker so that seems fine.

[situchan]

I think this is wrong bug report.
In @kbecciv's video, payment is settled in staging, not settled in production.
Grey should happen only when payment is settled and thus amount and description should not be editable.
In original logic, date section is active always no matter settled or not.

But from design perspective, it would be good to make date color follow others. So if greyed, apply grey, if not greyed. apply not grey.

[Julesssss]

Hmm good point but, I have a feeling our edit existing request PRs are still WIP.

[aimane-chnaif]

I think we can close this issue as staging and production actually behave the same.

[Julesssss]

I think we can close this issue as staging and production actually behave the same.

We should still make sure the UI for 'date' matches 'amount' and 'description'.

[aimane-chnaif]

I agree with consistency. We can also get feedback from @shawnborton

[shawnborton]

I think we are already working on fixing all of this, right @jasperhuangg @thienlnam ? None of this should have been grayed out in the first place. Anyways, I think we can just close this out.

[thienlnam]

We updated the task view so it floats above the chats like a reportAction, I thought there was a different issue for the IOU details to have the same done - do you happen to know if this issue exists @luacmartins?

[luacmartins]

I'm not aware of any issues doing this for IOUs

[aimane-chnaif]

Money request pages are being refactored in #22484
Here's design - #20486 (comment)

[luacmartins]

Ah nice! Thanks for linking that issue @aimane-chnaif

[melvin-bot]

🎯 ⚡️ Woah @aimane-chnaif / @c3024, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @c3024 got assigned: 2023-07-31 14:16:11 Z
• when the PR got merged: 2023-08-01 09:13:11 UTC

On to the next one 🚀

[spcheema]

@himanshuragi456 appreciate the nudge for the prior proposal :) @c3024 consider the doubling of the price to be your luck this time around, since enough time elapsed before we could review the proposal. You'll get the listed bounty 👍

@michaelhaxhiu we need you on anothe issue as well which been delayed too long time(20th Jun)😜

@aimane-chnaif is reviewing that as well. 😄

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• gray out date for settled money requests in MoneyRequestView #23927

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment offer (Reviewer)
• @c3024 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[michaelhaxhiu]

Note: I'm preparing to go OOO for ~2 weeks and need a BZ buddy to watch over this in the meantime. 🙏

Next steps:

Wait for 8/10 to arrive. After that's done, we'll process payments as follows (assuming no regressions 🤞):

• Bug reporter $250 for @daveSeife
• C+ $3000 for @aimane-chnaif
• Contributor $3000 for @c3024

I'll take this over when I return if it's not complete. Thanks in advance @adelekennedy

[adelekennedy]

I got you! Enjoy your ooo time!

[Julesssss]

Not overdue, waiting for payment date

[adelekennedy]

Payment Summary

@daveSeife - $250 for reporting bonus (paid via Upwork)
@c3024 - $2000 for fix and $1000 for speed bonus (paid via Upwork)
@aimane-chnaif - $2000 for fix and $1000 for speed bonus (paid via Upwork)

[c3024]

@adelekennedy I haven't received the payment. Has it been paid?

[adelekennedy]

@c3024 I keep trying to process it but Upwork keeps crashing 😬