[HOLD for payment 2023-07-14] [$1000] Bank Account – Icon on the left of “secure your account” in “validate bank account” section is not turning white like others when hovered.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open "Settings".
2. Click "Workspaces".
3. Click "Bank Account".
4. Click " Connect bank account".
5. Complete all steps until you reach the last step “Validate bank account”.

Expected Result:

Icon on the left of “secure your account” in “validate bank account” section should turn white like others when hovered.

Actual Result:

Icon on the left of “secure your account” in “validate bank account” section is not turning white like others when hovered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

3a.mp4

3.1.mp4

Recording.4979.mp4

Expensify/Expensify Issue URL:

Issue reported by: @usmantariq96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686379821898329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c9d2073930803828
• Upwork Job ID: 1670808482132348928
• Last Price Increase: 2023-06-26

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Shield icon in “validate bank account” section doesn't have hover effect

What is the root cause of that problem?

We're supplying iconFill color of Shield icon here which makes the color of this icon always is success color

App/src/pages/ReimbursementAccount/Enable2FAPrompt.js

Line 32 in 4c1739b

iconFill: themeColors.success,

What changes do you think we should make in order to solve the problem?

We only need to remove iconFill here to make the color of icon is not constant

App/src/pages/ReimbursementAccount/Enable2FAPrompt.js

Line 32 in 4c1739b

iconFill: themeColors.success,

What alternative solutions did you explore? (Optional)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hover colour of shield icon is not white

What is the root cause of that problem?

The root cause of the issue is that we're explicitly supplying a fill colour here.

What changes do you think we should make in order to solve the problem?

We just need to remove this line so that the fill colour is no longer defined explicitly.

What alternative solutions did you explore? (Optional)

None

[allroundexperts]

FYI, I posted the solution earlier here.

[gadhiyamanan]

FYI, I posted the solution earlier here.

@allroundexperts i think only bug reporter can propose a solution in slack

[allroundexperts]

FYI, I posted the solution earlier here.

@allroundexperts i think only bug reporter can propose a solution in slack

Oh, I did not know that @gadhiyamanan. Is this written somewhere?

[allroundexperts]

Posted about this here.

[gadhiyamanan]

According to CONTRIBUTING.md reporter may optionally propose a solution for that job on Slack and it will be reviewed in GitHub.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c9d2073930803828

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[kevinksullivan]

Not overdue, C+ is assigned to review proposals

[melvin-bot]

@eVoloshchak, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

Hi @eVoloshchak can you provide an update on reviewing these proposals?

[eVoloshchak]

The fix is pretty straightforward, I think we should proceed with @dukenv0307's proposal

@allroundexperts posted the same proposal earlier on Slack

🎀👀🎀 C+ reviewed!
cc: @kevinksullivan

[dukenv0307]

@eVoloshchak Can you check again? @allroundexperts isn't the reporter of this issue and it's invalid to post proposal in slack bug if the user isn't the reporter of this bug.

https://expensify.slack.com/archives/C049HHMV9SM/p1682976990688979?thread_ts=1682945338.708039&cid=C049HHMV9SM

[eVoloshchak]

@allroundexperts isn't the reporter of this issue

Ah, sorry for the confusion everyone
It is indeed against the rules to post a proposal on slack (unless you're the original reporter)

Let's proceed with @dukenv0307's proposal

[kevinksullivan]

Looks like we're just waiting on @marcaaron 's review to finish this out 👍

[marcaaron]

Merged 👍

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix shield icon hover effect #21548

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kevinksullivan]

@eVoloshchak please complete the steps above so we can pay this out on time. Thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Display banner to enable 2FA when setting up VBBA #12424

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12424/files#r1262735633

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is a simple visual bug

• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? No
  Is it an impactful bug? No
  This has almost no impact on user experience, a regression test isn't necessary

[kevinksullivan]

Before paying out, my understanding is this is NOT eligible for the merge bonus, as it took 5 business days from posting the PR (June 26) to it getting merged (July 3). Is that accurate @dukenv0307 @eVoloshchak ?

[eVoloshchak]

@kevinksullivan, I think PR was created as a draft before @dukenv0307 was assigned to the job

So this was technically merged in 1 business day, since July 1-2 was a weekend

[dukenv0307]

@kevinksullivan As @eVoloshchak said above, I create the draft before I was assigned to the job.

[kevinksullivan]

Thanks for clarifying @dukenv0307 @eVoloshchak . @eVoloshchak , I'm still waiting for you to accept the offer. Let me know once you've done so! And same for @usmantariq96 please let me know when you accept.

[kevinksullivan]

Paid @dukenv0307 !

[usmantariq96]

@kevinksullivan offer accepted with thanks.

[kevinksullivan]

Paid @usmantariq96

[eVoloshchak]

@kevinksullivan, I requested the payment via NewDot, so this can be closed now if that was the last action here

[anmurali]

Approved $1500 for @eVoloshchak based on #20932 (comment) and #20932 (comment)

[kevinksullivan]

Ah ok. I will cancel that offer and close this out.