[$1000] Not able to add a task assignee

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. click on + icon and click on Assign task option
2. enter title and click on Next button
3. click on Assignee option
4. click on any user

Expected Result:

user should be assign as Assignee

Actual Result:

not able to assign any Assignee

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: main
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686829718168319

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e2aaeba9308a0daa
• Upwork Job ID: 1669330942765027328
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

Hi I'm Ana from Callstack - expert contributor group - I can work on this issue.

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not able to add a task assignee

What is the root cause of that problem?

We have changed field in recent PR, assigneeAccountID was changed to newAssigneeAccountID

App/src/libs/actions/Task.js

Line 474 in 961d93c

let newAssigneeAccountID = Number(assigneeAccountID);

App/src/libs/actions/Task.js

Line 496 in 961d93c

Onyx.merge(ONYXKEYS.TASK, {assignee, newAssigneeAccountID});

But we are not using updated field here

App/src/pages/tasks/NewTaskPage.js

Line 81 in 4fdc8db

const assigneeDetails = lodashGet(OptionsListUtils.getPersonalDetailsForAccountIDs([props.task.assigneeAccountID], props.personalDetails), props.task.assigneeAccountID);

What changes do you think we should make in order to solve the problem?

We should change field name here

https://github.com/Expensify/App/blob/4fdc8dbec2cbd74190a68ca5008092a2dbbdbc16/src/pages/tasks/NewTaskPage.js#LL81C1-L81C1

to this

assigneeAccountID: newAssigneeAccountID

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e2aaeba9308a0daa

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Beamanator]

@eVoloshchak please review the proposal above when you have time!

[youssef-lr]

I'm getting this fixed in my PR here #20808.

[conorpendergrast]

Unassigning @eVoloshchak based on this being fixed in this PR, please correct me if that's wrong.

I'll hire @gadhiyamanan as bug reporter... when Upwork comes back

[conorpendergrast]

Contract sent to @gadhiyamanan via Upwork for bug bounty. I'll pay that when this is fixed by #20808

@youssef-lr I think you need to add this issue (#20807) to the fixed issues sections in that PR, right?

[conorpendergrast]

Ok, looks like the fix for this is on Staging now #20808

I'll re-test now on Staging

[conorpendergrast]

Tested on v1.3.29-1, and no issue with adding the task assignee 👍

[conorpendergrast]

Once that PR reaches production, I'll get that bug bounty paid and will close this issue

[youssef-lr]

Not overdue.

[conorpendergrast]

This is on Production: #20808

Time to pay!

[conorpendergrast]

Paid out @gadhiyamanan, ended contract. Closing!