[$1000] Attachment downloaded when user clicked outside the attachment button

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open staging.new.expensify.com
2. Send an attachment to a chat
3. Click the empty area outside the attachment button

Expected Result:

Attachment file shouldn't be downloaded since the user clicked outside the button

Actual Result:

Attachment file downloaded and could potentially caused confusion

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.784.mp4

Download.Click.mp4

Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684984471329289

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e0f07bfc53f77442
• Upwork Job ID: 1663611880864784384
• Last Price Increase: 2023-05-30

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachment downloaded when user clicked outside the attachment button

What is the root cause of that problem?

Currently, the Pressable component of Attachment reportAction is spread whole row => we can click anywhere in the row to trigger onPress to download attachment

What changes do you think we should make in order to solve the problem?

Instead of set styles.alignItemsStart here, we should set styles.dInlineFlex so the Pressable component of Attachment reportAction only display with inside content width.

Result:

[therealsujitk]

This is kind of a duplicate of #19017 (Same RCA), I think both of these can be fixed together. My proposal - #19017 (comment).

[hoangzinh]

@therealsujitk I don't think so. The expectation of #19017 would like to be able to press in whole IOU preview. But this issue would like to be able to press only in the attachment button, not the whole.

[therealsujitk]

@hoangzinh I believe in both cases the entire light green portion ONLY should be clickable. The same issue also exists for displayable attachments such as images and PDFs.

[greg-schroeder]

I reproduced this - and I tend to agree it looks like the same root cause as #19017

[greg-schroeder]

I'm asking the team to confirm

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We can click outside of attachment box to download it.

What is the root cause of that problem?

This is a regression of #17496 which we previously set align-items: start to the HTML renderer default view. Imagine that the attachment box (and its Pressable) is wrapped by a View that has a style of align-items: start. Now, it's removed and moved to the Pressable. So, the Pressable have the full width, while the attachment box still stay the same because we have the align-items: start on the Pressable.

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

Lines 81 to 82 in 619a529

	<AnchorForAttachmentsOnly
	style={styles.alignItemsStart}

App/src/components/AnchorForAttachmentsOnly/BaseAnchorForAttachmentsOnly.js

Lines 48 to 49 in 619a529

	<Pressable
	style={props.style}

This also happens with ImageRenderer.

What changes do you think we should make in order to solve the problem?

Wrap the Pressable with View and move the styles.alignItemStart there.

[greg-schroeder]

Okay, keeping this separate! Applying External accordingly

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e0f07bfc53f77442

[melvin-bot]

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[greg-schroeder]

@thesahindia thoughts on the proposals here and here?

[hoangzinh]

and my proposal here too #19717 (comment) 🤣

[greg-schroeder]

Ah yes, sorry @hoangzinh

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix task preview cursor is not pointer #21941

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Okay so we're finally ready for this one I believe!

[greg-schroeder]

@grgia @youssef-lr Per my comment here, a LOT happened with this issue...

Can anyone weigh in on the best way to pay this out? I'm honestly not sure because so many things went wrong here. There aren't really clear guidelines when so many things went awry and so many people were involved 😅

Discussed here a bit: https://expensify.slack.com/archives/C01SKUP7QR0/p1689717716471599

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @thesahindia is eligible for the External assigner, not assigning anyone new.

[greg-schroeder]

Hmm, I need to create a new upwork job I guess. Doing.

[greg-schroeder]

Sent offers to @bernhardoj @kerupuksambel. Given there were two regressions the 50% penalty was applied twice

@thesahindia you'll handle payment via newdot!

Payments due:

@kerupuksambel - $250: Issue Reporter
@bernhardoj - $250: Contributor (regression penalty x2)
@thesahindia - $250: Contributor+ (regression penalty x2)

[greg-schroeder]

Payments are complete, waiting for checklist @thesahindia

[greg-schroeder]

Bump on the above @thesahindia :)

[thesahindia]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:

#17496

• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#17496 (comment)

• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for a discussion. We don't need any change.

• [@thesahindia] Determine if we should create a regression test for this bug.

We don't need a test case

• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

N/A