[HOLD for payment 2023-06-07] [$1000] Web - Assign Task - Structure of the page broken when using long email as an Assignee

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to FAB -> Assign task
4. Enter a title and description and navigate to next page
5. Click on the "Assignee" and select account with a long name

Expected Result:

Structure of the page NOT broken (the standard arrows show)

Actual Result:

Structure of the page broken (the standard arrows do not show)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048384_Recording__4488.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01356421adda20a935
• Upwork Job ID: 1658893910462160896
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[zanyrenney]

At Accountex so won't get to this bug for a few days, reassigning.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Structure of the page broken when using long email as an Assignee

What is the root cause of that problem?

The Text component already has text-overflow is ellipsis:

But we haven't set its/parent's width with any specific style yet.

We have trick to ellipse main text here, but I think it's not a good idea

What changes do you think we should make in order to solve the problem?

There are few things to do because it and its parent element are lacking of some spacing styles:

1. Add styles.flex1 here so it can automatically take remaining spaces with arrow icon on
2. Add styles.w100 here and here
3. Add styles.flex1 here so it can automatically take remaining spaces with avatar.

We can remove the JS code of shorten main text here with above CSS change.

Result:

Beside that, current TaskSelectorLink component is messed with styles and elements:

• Redundant View component here
• No need flexColumn (default is flex-direction: column already), unrecognise styles.justify here
• No need styles.flexColumn here
• No need styles.flexRow here because only has 1 element

What alternative solutions did you explore? (Optional)

If we have valid reasons to use ellipse method for main text here, we can apply it for alternateText too.

[michaelhaxhiu]

I just noticed this - I am not sure why I am getting assigned, I am OOO till Monday. Re-assigning. Sorry for the surprise.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

I am testing this now

[muttmuure]

[muttmuure]

Also updated the expected outcome to clarify that we want to see the arrows shown above the long email

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01356421adda20a935

[hoangzinh]

@parasharrajat @hayata-suenaga PR is ready to code review #19547

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Truncate Task assignee email with ellipses when using long email when create a new Task #19547

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[muttmuure]

Vinh and Rajat have been invited to the job in Upwork

[parasharrajat]

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:#17992
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/17992/files#r1224292359
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1686316828519639
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #18659 (comment)

[parasharrajat]

Regression Test Steps

1. Go to FAB -> Click Assign task.
2. Enter a title and description and navigate to the next page
3. Click on "Assignee" and select a user with a shorter name.
4. Verify it shows the full Assignee name + email.
5. Click on the "Assignee" and select an account with a long name.
6. Verify it truncates with ellipses when the email/name is longer than create task page width.

Do you agree 👍 or 👎 ?

[hoangzinh]

@muttmuure It seems I haven't received the offer on Upwork yet.

[parasharrajat]

You should have received a job invite.

[hoangzinh]

Thanks @parasharrajat I didn't read the message carefully 👍 I just accepted job invite

[hayata-suenaga]

@muttmuure could you handle payment when you have time 🙇

[muttmuure]

Waiting for @parasharrajat and @hoangzinh to approve

[hoangzinh]

Accepted offer. Thanks @muttmuure

[muttmuure]

Everything is done