Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU - No "Decline" button appears next to each of the report requests #18527

Closed
5 of 6 tasks
kbecciv opened this issue May 6, 2023 · 9 comments
Closed
5 of 6 tasks

IOU - No "Decline" button appears next to each of the report requests #18527

kbecciv opened this issue May 6, 2023 · 9 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in HT account
  3. Navigate to a conversation with a user that you don't have any past IOUs.
  4. Complete the request money flow and send three payment requests, varying the length of the input string, to another account you have access to
  5. Log-in to the other account and click the view details button on the request in the DM
  6. Verify that the decline button is alongside the two expenses on the IOU

Expected Result:

"Decline" button should be appear next to each of the report requests

Actual Result:

No "Decline" button appears next to each of the report requests

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.11.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6044914_Recording__571.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 6, 2023
@OSBotify
Copy link
Contributor

OSBotify commented May 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 6, 2023

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Natnael-Guchima
Copy link

Natnael-Guchima commented May 6, 2023

This seem to be done by design on this PR

@Beamanator
Copy link
Contributor

Thanks @Natnael-Guchima - I agree this looks expected - I'll remove DeployBlockerCash and ask @luacmartins if you can confirm that this is now expected? If yes let's get testrail updated

@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label May 8, 2023
@Natnael-Guchima
Copy link

Thanks @Natnael-Guchima - I agree this looks expected - I'll remove DeployBlockerCash and ask @luacmartins if you can confirm that this is now expected? If yes let's get testrail updated

You are welcome @Beamanator 🙌

@Beamanator
Copy link
Contributor

@vitHoracek confirmed this is the expected behavior now - @kbecciv can you make a note to remove this from testrail? I believe there will be lots of new checklist items once the "Manual requests" project is completed (cc @luacmartins @Julesssss )

@luacmartins
Copy link
Contributor

We have changed this behavior and no longer support Decline. That functionality was replaced with Delete, but only for the person who requested money. The payer of that request should not see anything.

@kbecciv
Copy link
Author

kbecciv commented May 8, 2023

@luacmartins Please submit a "QA - Add/Update test to TestRail" ticket.

@luacmartins
Copy link
Contributor

@kbecciv created here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants