Deploy Checklist: New Expensify 2023-05-05

[OSBotify]

Release Version: 1.3.11-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Detailed list of reaction senders when long-/right-pressing a reaction #15685
• Add unlink secondary login flow #15811
• Fix replay effect #16545
• Create DeleteMoneyRequest command #17583
• Optimistically generate transactions in existing IOU flows #17718
• Fix for: Editing workspace name to 1to3 characters adding extra line in the optional message when inviting users in Spanish #17878
• fix: consistent lhn preview for archived chats #18019
• [No QA] Create Money Request Header component #18148
• [No QA] 17885 custom user mentions renderer #18167
• Styling Help for MoneyRequestHeader #18247
• fix: payment page title spacing #18253
• Fix enter key behavior changes after resizing window to small screen #18337
• Fix: Workspace picture not update in LHN #18354
• [ContextMenu] Do not drag window on click and drag action on the context menu #18365
• Deprecate the default rooms beta for #admins and #announce rooms #18393
• Only subscribe shortcuts when modal is open #18425
• Revert "fix add reaction icon position changed when user add emoji" #18430
• Improve the many writes error message #18439
• [No QA] Use Onyx.METHOD and remove redundant CONST.ONYX.METHOD #18464
• Fix header with close button styles #18465
• Fix: Close account - Unable to close a phone number account, error is displayed #18470
• Revert "[No QA] 17885 custom user mentions renderer" #18490
• Fix arrow focus shortcut modal local state (v2.0) #18599
• Additional changes for #17202 #18611
• [CP Stg] Fix bad merge #18619

Deploy Blockers:

• [HOLD for payment 2023-05-16] Unable to use keyboard arrow navigation in the list if open "new chat" #18516
• [HOLD for payment 2023-05-16] Login - Keyboard doesn't popup after going back to login screen on Android app #18525
• IOU - No "Decline" button appears next to each of the report requests  #18527

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.11-1 🚀

[Beamanator]

FYI it looks like #18527 may not be a deploy blocker, confirming with author of this PR

• Confirmed internally here, marking that one off

[mvtglobally]

@Beamanator regression is completed

PR #15811 is failing #18526
PR #18253 can you help us out with it?
PR #18365 is failing #18608 repro in prod. Checking off
PR #18470 is failing. Getting the issue in a few (#17976)

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.11-3 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.11-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.11-3 has been deployed to staging 🎉

[roryabraham]

Aldo confirmed that #18516 is resolved, checking it off.

[roryabraham]

I verified that #18525 is resolved, checking it off.

[roryabraham]

The issue with #15811 should be resolved in 1.3.11-5 by #18619

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.11-5 🚀

[roryabraham]

I wasn't able to manually verify #18253 on staging because I see a balance on my Payments page, but the PR is safe enough and the bug simple enough that I don't think we'll block deploy on that. Checking it off.

[roryabraham]

Seems like #18465 was just missed, going to verify that one now...

[mvtglobally]

#18465 is pass. @roryabraham looks like i just missed to check it off.

[roryabraham]

Verified #18465 (comment)

[mvtglobally]

#18425 has been verified last regression. its pass. it just hasn't deploy to prod yet. OK to check it off or we need to verify again?

[roryabraham]

Ok, here's the status for everything left unchecked here:

• Add unlink secondary login flow #15811 should be fixed in 1.3.11-5
• Only subscribe shortcuts when modal is open #18425 needs retest, should have been fixed by Fix arrow focus shortcut modal local state (v2.0) #18599 in 1.3.11-3
• [CP Stg] Fix bad merge #18619 cherry-picked in 1.3.11-5

[roryabraham]

#18425 has been verified last regression. its pass. it just hasn't deploy to prod yet. OK to check it off or we need to verify again?

It's not expected that this be deployed to prod until this checklist is closed. So it sounds like we are good to check it off

[roryabraham]

Okay, last thing to do is retest #15811 in 1.3.11-5, which is deploying here.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.11-5 has been deployed to staging 🎉

[roryabraham]

Verified on staging, let's do this thang.

[roryabraham]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[roryabraham]