Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeplinks - "doesn't have access" page instead of LHN #17390

Closed
2 of 6 tasks
kbecciv opened this issue Apr 13, 2023 · 16 comments
Closed
2 of 6 tasks

Deeplinks - "doesn't have access" page instead of LHN #17390

kbecciv opened this issue Apr 13, 2023 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 13, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open NewDot app and login
  2. Navigate to each of the following links

https://staging.new.expensify.com/r/6821704960193694/details

https://staging.new.expensify.com/r/6821704960193694/participants

https://staging.new.expensify.com/r/6821704960193694/settings

Expected Result:

User should be redirected to the to the LHN in each link

Actual Result:

User is redirected to "doesn't have access" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.99.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3363141

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6016476_video_06__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 13, 2023
@MelvinBot
Copy link

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kbecciv
Copy link
Author

kbecciv commented Apr 13, 2023

QA team is failing the TR steps

image

@kbecciv
Copy link
Author

kbecciv commented Apr 13, 2023

Linking this Hold KI #12676

@MitchExpensify
Copy link
Contributor

This is not actually expected behavior as far as I know:

"User should be redirected to the to the LHN in each link"

When you try access a report that you don't have access to we expect to be shown the "Hmm.. it's not here" page. CC @jasperhuangg and @thienlnam as you are both close to these flows 😄

@thienlnam
Copy link
Contributor

Yeah this seems like it is working correctly?

Like unless the user actually has access to those reports they should be seeing that "Hmm.. it's not here" unless it's a public room

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@MitchExpensify
Copy link
Contributor

Agreed! Closing

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@thienlnam thienlnam reopened this Apr 17, 2023
@thienlnam
Copy link
Contributor

Going to re-open so we can address the TR case where this happens - @isagoico Could we please get this updated to

Changes:
For the last VERIFY step in the TR, it should be the same as the first VERIFY step

@MitchExpensify
Copy link
Contributor

Oh whoops, yes good call @thienlnam

@melvin-bot melvin-bot bot added the Overdue label Apr 20, 2023
@MitchExpensify
Copy link
Contributor

@isagoico Could we please get this updated to:

Changes:
For the last VERIFY step in the TR, it should be the same as the first VERIFY step

Lil bump on this please 😄

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 20, 2023
@MelvinBot
Copy link

@MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam
Copy link
Contributor

From this slack message, updating TR steps are getting distributed - @mvtglobally could you please help us take care of this update?

#17390 (comment)

@mvtglobally
Copy link

Will check it out today

@mvtglobally mvtglobally self-assigned this Apr 24, 2023
@mvtglobally
Copy link

@thienlnam Let me know if there is anything else required to be added here
Screen Shot 2023-04-24 at 9 54 02 PM

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2023
@thienlnam
Copy link
Contributor

Looks great, thanks!

@MelvinBot
Copy link

@MitchExpensify Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants