[HOLD for payment 2023-08-07] [$250] Migrate WalletStatementPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/wallet/WalletStatementPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01120a3696c71dc1f1
• Upwork Job ID: 1674855096251645952
• Last Price Increase: 2023-06-30

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[muxriddinmuqimov77]

I'd like to work on this issue when it goes to external

[s-alves10]

I'd love to work on this.

[marcaaron]

Taking this one off HOLD.

[code0406]

I am eager to take on this task.

[dayana7204]

I am ready to work on this ticket :)

[vdem0115]

I would like to work on this issue.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01120a3696c71dc1f1

[melvin-bot]

Everybody was OOO, so I assigned the only eligible person.

[melvin-bot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[MitchExpensify]

Bump @Santhosh-Sellavel 👍

[PauloGasparSv]

Bump @Santhosh-Sellavel 👍

Hey @MitchExpensify the review is blocked because of me now I think.

Since this change is related to the Wallet @Santhosh-Sellavel and @s-alves10 can't really test this, I'm trying to figure out how they can test it though (I think it's related to enabling the wallet beta, trying to do this on my local dev environment first).

I only stopped to focus on this now but @s-alves10 also tried reaching out in the Cplus channel for an account that can test this but didn't get help there.

Will give an update here and reach out to the team if I can't find out how to test this.

[MitchExpensify]

Sounds good, thanks @PauloGasparSv !

[PauloGasparSv]

Hey @MitchExpensify can you please re-assign this to another engineer?

I'm OOO from now till next week (tried to review this before going OOO but couldn't, sorry for that).

To whoever takes this on and isn't sure on how to set up a wallet, please refer to this S.O. https://stackoverflowteams.com/c/expensify/questions/10083 and can you please help with this comment?

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MitchExpensify]

Hey @MitchExpensify can you please re-assign this to another engineer?

Done!

@AndrewGable Looks like the latest on this is that we ran into problem testing it #16303 (comment)

[melvin-bot]

@AndrewGable, @MitchExpensify, @Santhosh-Sellavel, @s-alves10 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @s-alves10 got assigned: 2023-07-03 21:15:52 Z
• when the PR got merged: 2023-07-27 20:28:59 UTC
• days elapsed: 17

On to the next one 🚀

[melvin-bot]

@AndrewGable, @MitchExpensify, @Santhosh-Sellavel, @s-alves10 Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

Not overdue - PR hit staging so payment 7 days after it hit production assuming no regressions is our next step

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• refactor: WalletStatementPage to function component #22152

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)
• @s-alves10 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MitchExpensify]

Reminder added to cal to pay out on 8/7 👍

Payment summary:

Reporting - None
C @s-alves10: $250
C+ @Santhosh-Sellavel : $250

Does that look right to you both? 🙇

[s-alves10]

This migration took long because it's hard to test. Please check the review history of the PR.
Thanks

[MitchExpensify]

This migration took long because it's hard to test. Please check the review history of the PR.

Yes I noticed that in the PR but I'm not sure we can take that into account for bonuses. For example we do not consistently factor in review delays because it is too time consuming. That said, if @AndrewGable agrees the difficulty testing should be factored in I'm happy to ignore the 50% late merge penalty!

[AndrewGable]

There was also some internal OOO that added to this, no need to add the penalty.

[MitchExpensify]

Ok cool! Thanks @AndrewGable & @s-alves10 - I've edited the payment summary accordingly

[MitchExpensify]

Paid! Thanks everyone