[$1000] Workspace name changes to old name when user switch from offline to online

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. open the app
2. switch to offline mode
3. create new workspace
4. go to General settings of the workspace and change the name
5. go back to Workspace screen
6. switch to online mode

Expected Result:

workspace name should not changed to old name

Actual Result:

workspace name changes to old name

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.87-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-15.at.3.02.35.PM.mov

Recording.132.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678873050270689

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0130314f12ef1184f1
• Upwork Job ID: 1638886511416467456
• Last Price Increase: 2023-03-23

[MelvinBot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0130314f12ef1184f1

[MelvinBot]

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[greg-schroeder]

Reproduced, added External

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[MelvinBot]

Triggered auto assignment to @MonilBhavsar (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MonilBhavsar]

We just merged this PR to fix this general issue. And I believe this issue should be fixed by it. Let me do quick test

[abekkala]

I unassigned myself as I don't think that it needed a double BZ assignment here.
If someone else does need to be assigned please re-aaply the Bug label as I'm ooo until Tue April 04

[MelvinBot]

@parasharrajat, @greg-schroeder, @MonilBhavsar Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MonilBhavsar]

Seems like a different issue and open to proposals.

[koko57]

I'll take a look :)

[MelvinBot]

📣 @koko57 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

@koko57 Please post your approach here before moving to PR. Thanks.

[BeeMargarida]

Hi, Ana from Callstack here, I'll take over from @koko57, will investigate and post a proposal

[MonilBhavsar]

Thank you!

[MelvinBot]

📣 @BeeMargarida You have been assigned to this job by @MonilBhavsar!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[parasharrajat]

@BeeMargarida Please post your approach here before moving to PR. Thanks.

[MelvinBot]

@parasharrajat @BeeMargarida @greg-schroeder @MonilBhavsar this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[BeeMargarida]

Currently in the process of writing a proposal, been busy with other issues, will pick this up today.

[BeeMargarida]

Update: still investigating, trying to find a fix

[BeeMargarida]

This is not a proposal yet, because I would like to gather more information, since there's a part of what is happening that I can't observe.

Problem

When a user creates and edits a workspace name while offline, when returning to online the workspace name reverts to the original one.

Root cause

After analysing the requests made after reconnect, all seems fine with the information sent and the order of the events (createWorkspace -> updateWorkspaceGeneralSettings -> reconnectApp).

When analysing the data received by Onyx, there’s an update after the reconnect that contains outdated data. As it can be seen in the images below, the first one contains changes related to the update on the policy general settings. However, the second one, which comes bundled with updated data regarding the reports, contains outdated data regarding the policy. This is then merged and the correct data is overwritten with the old one.

Tracing back this request, it's received by Pusher (image below). Based on the comment Receive any relevant Onyx updates from the server, I’m not sure if it means Expensify's web server/backend. Either way, I can’t trace it backwards anymore because I don’t know who/what triggered this pusher event.

I've checked if any of the Onyx merge/set requests in the App are being called after reconnect, but that is not the case. Does anyone know more about how it works in the backend and can provide knowledge about what might be triggering this event?

[BeeMargarida]

Hi, any update regarding this? There's a possibility of it being related to this issue: #12775

[parasharrajat]

@MonilBhavsar can you please help with this?

[parasharrajat]

I agree it is good to add this issue to the tracking issue #12775

[MelvinBot]

@parasharrajat @BeeMargarida @greg-schroeder @MonilBhavsar this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[MonilBhavsar]

Sorry, I was ooo. Taking a look now

[MonilBhavsar]

I think I agree that it is related to relay effect and possibly duplicate of #12000

[neil-marcellini]

Yes good call. I'm closing it since it's a duplicate of #12000