Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name #12000

Closed
kbecciv opened this issue Oct 19, 2022 · 43 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Log in with any account
Go offline
Create a new worksapce
Rename the workspace Workspace
Go back to the settings and go back online

Expected Result:

The workspace remains renamed

Actual Result:

The workspace is reverted to the initial name until you refresh.

Workaround:

Refresh.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-11-28.at.9.06.06.AM.mov

Out-dated video when the bug occurred while online.
https://user-images.githubusercontent.com/93399543/196772472-9c6035bd-2064-46d9-a847-9149a55f623c.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 19, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2022

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@ctkochan22
Copy link
Contributor

This is reproducible on prod. Not a deploy blocker

@ctkochan22 ctkochan22 added Daily KSv2 Hourly KSv2 Improvement Item broken or needs improvement. and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Oct 19, 2022
@ctkochan22
Copy link
Contributor

Looks like the workspace name is reverting after we get the message:
image

@kbecciv
Copy link
Author

kbecciv commented Oct 19, 2022

We used Deploy Blocker label, because we can not reproduce it in production

@ctkochan22
Copy link
Contributor

ctkochan22 commented Oct 20, 2022

Oh let me try again to make sure.

Edit:
Yeah, here is a video in prod: https://recordit.co/uBLVs3klWR

I'm more than confident its happening with the Concierge message.

@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@ctkochan22
Copy link
Contributor

This only happens if they change the name before you get an automatic message about guides

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 25, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

@ctkochan22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@ctkochan22
Copy link
Contributor

Still happening. I think this is internal, need to test what keys are being updated when the message about the guidse comes though

@neil-marcellini
Copy link
Contributor

I'm going to make this monthly while it's on HOLD.

@melvin-bot melvin-bot bot removed the Overdue label Nov 17, 2022
@neil-marcellini neil-marcellini added Monthly KSv2 and removed Daily KSv2 labels Nov 17, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Fourth week). Can we close this as its not repro?

@JmillsExpensify
Copy link

@neil-marcellini What do you think? Given that QA isn't able to reproduce this any long I'm inclined to close, or we need to update the reproduction steps so it's more clear how Applause can get the same result.

@neil-marcellini
Copy link
Contributor

I tested on staging and it looks like it's no longer reproducible while online, which is kind of odd. I'm not sure how it was fixed but that's good. However the issue is still reproducible when the workspace is created and renamed while offline. I will update the description.

@JmillsExpensify JmillsExpensify changed the title [HOLD Expensify 242444] Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name [HOLD #12775] Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name Nov 28, 2022
@JmillsExpensify
Copy link

Thanks! I'll also take this over as part of the broader tracking initiative. Feel free to assign yourself to #12775 as well.

@JmillsExpensify
Copy link

Still holding and not a priority.

@JmillsExpensify
Copy link

Still far from being a priority.

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@neil-marcellini
Copy link
Contributor

We are still holding this on #12775. I'm suggesting that we start working on that issue again.

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@JmillsExpensify
Copy link

Awesome that sounds great!

@melvin-bot melvin-bot bot added the Overdue label Mar 20, 2023
@neil-marcellini
Copy link
Contributor

Holding, we have a potential solution for #12775.

@neil-marcellini
Copy link
Contributor

Still holding, see the updates in the replay effect issue.

@melvin-bot melvin-bot bot removed the Overdue label Apr 21, 2023
@JmillsExpensify JmillsExpensify removed the Improvement Item broken or needs improvement. label May 5, 2023
@neil-marcellini neil-marcellini changed the title [HOLD #12775] Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name May 16, 2023
@neil-marcellini
Copy link
Contributor

Fixed!

Screen.Recording.2023-05-16.at.8.54.42.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Monthly KSv2
Projects
None yet
Development

No branches or pull requests

8 participants