[$1000] Chat - The reaction emoji left on the loading comment disappears

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log in with any account
3. Go to any chat
4. Click on + button -> Add attachment -> Choose an attachment
5. While the attachment is loading, post a reaction on it

Expected Result:

The reaction emoji does NOT disappear.

Actual Result:

The reaction emoji disappears.
The reaction emoji appears again only after refreshing the page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.85.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5979162_Recording__3920.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - internal Team , @priya-zha

Slack conversation: Mitch adding: https://expensify.slack.com/archives/C049HHMV9SM/p1678342357605789

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc619aac23e0b3e8
• Upwork Job ID: 1636061165738586112
• Last Price Increase: 2023-04-07

[MelvinBot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01dc619aac23e0b3e8

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

[mallenexpensify]

@MitchExpensify I was checking to see what automation we did once the Internal label was added. Feel free to proceed as normal from here

[MitchExpensify]

@mallenexpensify I think @kbecciv doesn't have Slack access, should they? (In order to link the Slack convo)

[MitchExpensify]

Theres a thread from 10 days ago here when Priya reported this. Seems like this was before Applause reported it here - I think we should give Priya reporting credit unless I'm missing something

[Snehal-Techforce]

Proposal

Root Cause:
During uploading of any attachment emoji are applied, at that time the image is not fully uploaded and merging of that reaction is not completed. Hence, emojis are not being displayed for the first time without refreshing the page.

Solution:

So, in this case it is recommended NOT to show the emoji tab during the attachment upload process.

To achieve this behavior an extra condition ( which verifies that the attachment is processing state or not ) needs to add in the ReportActionItem.js file. So, until the image is uploaded properly, the tab of emoji reaction will not display on the right side of the page to apply emoji.

Moreover to remove the tooltip box ( which appears when we right click ) while uploading an attachment, the same condition needs to be added in ReportActionItem.js at line no 120.

Expected Output:

[mallenexpensify]

I think @kbecciv doesn't have Slack access, should they? (In order to link the Slack convo)

I don't think it's a necessity that all QA team have access to Slack, mainly because it hasn't come up much the past 2+ years and cuz BZ can easily add if needed (right?)

[parasharrajat]

I am not sure about the state of this issue. Is it internal or external? @MitchExpensify

[MitchExpensify]

Ah good catch, it can be external right @parasharrajat ? I.e. Mostly front end work

[parasharrajat]

I haven't analyzed the root cause but it might be a backend issue or require both frontend and backend.

we can still make it external and later if we see backend changes is needed, it can be switched to internal.

[MelvinBot]

Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @parasharrajat is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Upwork job price has been updated to $1000

[aldo-expensify]

Reverting price to $1000 since we are waiting for the proposals reviews

[aldo-expensify]

Friendly bump @parasharrajat .

[MelvinBot]

@parasharrajat @MitchExpensify @aldo-expensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[parasharrajat]

Going to check it soon or gonna assign someone else.

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MelvinBot]

@parasharrajat, @MitchExpensify, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@parasharrajat, @MitchExpensify, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Shall we re-assign this @parasharrajat or can you get to it today or tomorrow perhaps?

[parasharrajat]

Gonna post a Slack thread. I am confused about what should be the best thing to do here. I was expecting to get more proposals on #15998 (comment).

[MitchExpensify]

Nice, did you post a Slack thread out of curiosity @parasharrajat? Keen to follow along as this issue is starting to drag on a bit

[MelvinBot]

@parasharrajat @MitchExpensify @aldo-expensify this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[MelvinBot]

Current assignee @parasharrajat is eligible for the Internal assigner, not assigning anyone new.

[MitchExpensify]

I'm going to post in the C+ room to see if anyone else has bandwidth to help out here @parasharrajat

[parasharrajat]

That works. Thanks.

[MitchExpensify]

Cool, shared here!

[MitchExpensify]

Similar to here, closing due to the deprecation of loading messages