[HOLD for payment 2023-03-17] The hint below text box in "Add a bank account" flow is not left aligned.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app.
2. Open settings
3. Open Workspaces, select any workspace.
4. Go to connect bank account and fill step 1.
5. Notice that the "PO box", "e.g" text hints are not left aligned with the text input

Expected Result:

The hints should be left aligned with the input just like other places in the app.

Actual Result:

The hint have an unnecessary padding.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.79-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @Prince-Mendiratta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678098395693209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ae68840656981d2
• Upwork Job ID: 1633207912847650816
• Last Price Increase: 2023-03-07

[MelvinBot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~017ae68840656981d2

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

[luacmartins]

Reassigning the issue to @mananjadhav since he's already assigned to the PR

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix TextInput hint alignment #15722

If no regressions arise, payment will be issued on 2023-03-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Text & Dropdown Input Styles #12447
• [@mananjadhav / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Text & Dropdown Input Styles #12447 (comment)
• [@mananjadhav / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A already covered by checklist
• [@davidcardoza] Determine if we should create a regression test for the bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@davidcardoza] Review the proposed regression test steps and location.
• [@davidcardoza] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[mananjadhav]

@davidcardoza As requested last time here's a summary of the payout:

1. Reporting Bonus - @Prince-Mendiratta $250
2. C+ Review Internal PR - @mananjadhav $1000

@luacmartins do you think we need a regression test for this one? I am of the opinion we don't, but do let me know if you think it's needed.

[luacmartins]

I agree that we don't need it.

[mananjadhav]

@davidcardoza quick bump on this one.

[luacmartins]

@mananjadhav could you please address the other items on [this checklist](#15698 (comment)? It's a bit crazy for me at the moment coming back from ECX.

[davidcardoza]

@mananjadhav Contracts sent. Sorry for the delay I was pretty logged off last week as a project lead for ExpensiconX

[mananjadhav]

No worries @davidcardoza. Accepted.

@luacmartins I’ll get to it by tomorrow

[mananjadhav]

@luacmartins I tried checking the offending PR but it seems FormHelpMessage has gone through iterations. Earlier this used DotIndicatorMessage. We added FormHelpMessage in this PR. I am not sure how do we link it further.

[luacmartins]

I'm pretty sure that this is the offending PR since it updated the input styles, but didn't take into account hints.

[luacmartins]

I completed the checklist. I also don't think that we need regression tests in this case.

[situchan]

@mananjadhav @luacmartins I think you can find helpful comment after reading last part of this thread
Maybe https://expensify.slack.com/archives/C01GTK53T8Q/p1677758582523269?thread_ts=1676895140.727779&cid=C01GTK53T8Q

[luacmartins]

@davidcardoza have we processed the payments for this issue?

[mananjadhav]

@luacmartins C+ payment is processed, I am not sure about Reporting bonus.

[davidcardoza]

Both contracts have been paid, screenshot below for reference. Closing.

[luacmartins]

thanks @davidcardoza !