[HOLD for payment 2023-02-15] Settings- Blank page is displayed after remove the User B from member list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #14596

Action Performed:

1. Log in with expensifail account with user A in Web
2. Create a workspace by user A
3. Add user B as member
4. Log in in Android app as User B
5. For user B, go to #announce > details > members
6. For user A, add a new member to the workspace
7. Remove user B from member as user A in Web

Expected Result:

Page is not found should be displayed when removed user B from member list

Actual Result:

Blank page is displayed after remove the User B from member list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.62.0

Reproducible in staging?: Yes

Reproducible in production?: Yess

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230130_180550_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012cdb42cd3e325164
• Upwork Job ID: 1621225716890148864
• Last Price Increase: 2023-02-02

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[alexpensify]

I didn't get a chance to test today and will review it when I'm back online on Thursday since I'm OOO tomorrow.

[luacmartins]

I can reproduce this.

[luacmartins]

@shawnborton do we have any content we'd like to show in the RHN in this case? This is what it looks like with the not found component:

[alexpensify]

@luacmartins thanks for confirming! Can you clarify after Shawn reviews, whether will you add the Internal or External tag? I'm trying to gauge the next steps here. Thanks!

[luacmartins]

Ah yea, I'll handle this one. Adding the Internal label.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012cdb42cd3e325164

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[alexpensify]

Thanks!

[alexpensify]

This one is still under review.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add not found page to report RHN workspace detail pages #14744

If no regressions arise, payment will be issued on 2023-02-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak / @luacmartins] The PR that introduced the bug has been identified. Link to the PR: Report Details and Settings for User Created Policy Rooms #7028
• [@eVoloshchak / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Report Details and Settings for User Created Policy Rooms #7028 (comment)
• [@eVoloshchak / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1676380612408559
• [@eVoloshchak] Propose regression test steps to ensure the same bug will not reach production again. [HOLD for payment 2023-02-15] Settings- Blank page is displayed after remove the User B from member list #14683 (comment)
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

@luacmartins - Can you share the link to the regression test? I don't see it in this GH or a plan to point to. Thanks!

[luacmartins]

@eVoloshchak would you mind filling the checklist above please?

[luacmartins]

@alexpensify these should be the regression test steps, but I'd wait for @eVoloshchak to fill the checklist above:

1. Log in with two users, A and B
2. As user A, create a workspace + > New workspace
3. As user A, Invite user B to the workspace, + > Workspace > Manage members > Invite
4. As user B, go to #announce > details > members
5. As user A, remove user B from the workspace
6. As user B, verify that you see a Not found page in the RHN
7. Repeat steps 1-8, but this time go to the following pages in step 6: #announce > details and #announce > details > settings

[alexpensify]

@eVoloshchak - when you get a chance, can you reply to @luacmartins? Thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Report Details and Settings for User Created Policy Rooms #7028

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Report Details and Settings for User Created Policy Rooms #7028 (comment)

• discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1676380612408559

[alexpensify]

@luacmartins - do we agree with these steps?

[luacmartins]

@alexpensify yea, all good! BZ checklist is completed!

[alexpensify]

@luacmartins - I believe the next step is for me to start the payment process in Upwork. I'll do so tomorrow.

[eVoloshchak]

Btw, the Upwork job is private

[alexpensify]

@eVoloshchak - I've initiated the process in Upwork and you should have access to the contract now. Please accept and I can move forward with payment. Thanks!

[eVoloshchak]

Accepted the offer, thanks

[alexpensify]

Closing - I've completed the payment via Upwork.