Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Timezone - Console error appears when come back online after changing Timezone offline #13311

Closed
kbecciv opened this issue Dec 3, 2022 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 3, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #12201

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and login
  2. Change URL to ".....staging.new.expensify.com/settings/profile/timezone"
  3. Go offline
  4. Change Timezone
  5. Back online

Expected Result:

No Console error appears when come back online after changing Timezone offline

Actual Result:

Console error appears when come back online after changing Timezone offline

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.36.0

Reproducible in staging?: Yes

Reproducible in production?: new feature

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5847060_video_56.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 3, 2022

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@aldo-expensify
Copy link
Contributor

I think this is not related to the timezone page, I have seen this happening when you disable the connection in your computer/mac, but the app has not yet updated the offline/online state. Since there is no internet connection, but the App thinks there is, it tries to send the requests in a retry loop and all of them fail. You can see that this is the case because if the App had detected correctly that you were offline, you would have seen the message "You appear to be offline":

image

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2022
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Dec 6, 2022

Maybe we should create a new GH issue that describes the problem above, but I don't think we have a reliable way of reproducing it.

@marcaaron
Copy link
Contributor

also maybe the site was just down when this happened? It went down at some point today IIRC.

@marcaaron
Copy link
Contributor

Reproducible in production?: new feature

What about this is a new feature?

@marcaaron
Copy link
Contributor

Oh, I see, it's a new page just for timezones.

@marcaaron
Copy link
Contributor

Can't reproduce this one. Gonna close it since we don't have a good lead on what happened for tester. Feel free to reopen if anyone disagrees.

@marcaaron marcaaron closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@melvin-bot melvin-bot bot removed the Overdue label Dec 6, 2022
@aldo-expensify
Copy link
Contributor

also maybe the site was just down when this happened? It went down at some point today IIRC.

I don't think so, the video was taken 2 days ago, also you can see in the video that they disconnected the wifi to go offline, but the App didn't react to it.

@marcaaron
Copy link
Contributor

Got it, thanks. Should we reopen then? Maybe with the Needs Reproduction label?

@aldo-expensify
Copy link
Contributor

Nah, this GH issue description/title will be misleading of the actual cause. I'll create a new GH issue describing the connection state not reacting to an offline connection and add the Needs Reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants