-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Timezone - Console error appears when come back online after changing Timezone offline #13311
Comments
Triggered auto assignment to @flaviadefaria ( |
I think this is not related to the timezone page, I have seen this happening when you disable the connection in your computer/mac, but the app has not yet updated the offline/online state. Since there is no internet connection, but the App thinks there is, it tries to send the requests in a retry loop and all of them fail. You can see that this is the case because if the App had detected correctly that you were offline, you would have seen the message "You appear to be offline": |
Maybe we should create a new GH issue that describes the problem above, but I don't think we have a reliable way of reproducing it. |
also maybe the site was just down when this happened? It went down at some point today IIRC. |
What about this is a new feature? |
Oh, I see, it's a new page just for timezones. |
Can't reproduce this one. Gonna close it since we don't have a good lead on what happened for tester. Feel free to reopen if anyone disagrees. |
I don't think so, the video was taken 2 days ago, also you can see in the video that they disconnected the wifi to go offline, but the App didn't react to it. |
Got it, thanks. Should we reopen then? Maybe with the |
Nah, this GH issue description/title will be misleading of the actual cause. I'll create a new GH issue describing the connection state not reacting to an offline connection and add the |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing PR #12201
Action Performed:
and login
Expected Result:
No Console error appears when come back online after changing Timezone offline
Actual Result:
Console error appears when come back online after changing Timezone offline
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.36.0
Reproducible in staging?: Yes
Reproducible in production?: new feature
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5847060_video_56.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: