[$1000] Bug: Triple clicking a DM that contains text and URL, the URL isn’t highlighted

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Go to a chat which has text and an URL
3. Triple click on the message

Expected Result:

URL also should get highlighted

Actual Result:

URL is not getting highlighted

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Desktop app
• Web app

Version Number: 1.2.12-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

xI1c5IprVd.mp4

Recording.673.mp4

Expensify/Expensify Issue URL:
Issue reported by: @michaelhaxhiu
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665524227683689

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Christinadobrzyn]

• I can also recreate this on the desktop app
• I don't see any other GHs about this issue so sending it to eng!

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[michaelhaxhiu]

@Christinadobrzyn 👋 just chiming in to say that you should feel free to update the GH to include desktop app in the list of affected platforms next time! I added it this time, but that's a valuable addition when triaging :)

[strepanier03]

@youssef-lr - just a friendly bump here. Is this something you have the bandwidth to work on or should it go back to the pool?

[michaelhaxhiu]

Heads up Youssef is OOO today and posted internally in #social. I'm sure he'll get to it monday!

…

On Fri, Oct 14, 2022 at 2:45 PM Sheena Trepanier ***@***.***> wrote: @youssef-lr <https://github.com/youssef-lr> - just a friendly bump here. Is this something you have the bandwidth to work on or should it go back to the pool? — Reply to this email directly, view it on GitHub <#11735 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADEYK4G6QMAH5USOJG3C353WDGS53ANCNFSM6AAAAAARCXGAH4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Michael Haxhiu

[melvin-bot]

@youssef-lr Eep! 4 days overdue now. Issues have feelings too...

[youssef-lr]

I agree this is an issue, adding External.

[melvin-bot]

Triggered auto assignment to @muttmuure (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[eVoloshchak]

@Ollyws's proposal is good, resolves the current issue, URL's are highlighted when triple-clicking a DM.

Secondly, userSelect is disabled on small screens rendering the link unselectable

I think that's the expected behavior

However, it introduces a new bug when copying a fully selected message to a clipboard. If you triple-click a DM and then press Cmd+C, it seems to append the concierge welcome message to the selected message

Screen.Recording.2022-11-16.at.19.37.04.mov

[Ollyws]

@eVoloshchak Interesting, that bug only started to occur when I pulled the latest changes.
It doesn't seem to occur if you apply the changes from @wildan-m's latest PR

[thesahindia]

If you triple-click a DM and then press Cmd+C, it seems to append the concierge welcome message to the selected message

That's an already known bug which we are handing at #12730

[eVoloshchak]

@Ollyws, @thesahindia, cool cool, thank you for pointing to that PR

In that case I think we should proceed with @Ollyws's proposal (minus the part with disabled userSelect on small screens)

🎀👀🎀 C+ reviewed!
cc: @chiragsalian

[chiragsalian]

Sounds good, @Ollyws proposal LGTM as well. Feel free to create the PR @Ollyws.

[melvin-bot]

📣 @Ollyws You have been assigned to this job by @chiragsalian!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Ollyws]

All yours @eVoloshchak. Let's see if we can get this merged within three days!

[muttmuure]

@chiragsalian is this complete?

[eVoloshchak]

@muttmuure, this was deployed to staging a couple of hours ago

[chiragsalian]

Yes, its on staging right now but not on production just yet.

[muttmuure]

The job posting had expired (sorry!) but I've created a new one and it's here.

https://www.upwork.com/jobs/~01d70533c5adde99c5

@Ollyws @eVoloshchak please apply and we can get you both paid.

[Ollyws]

@muttmuure Applied, thanks!

[muttmuure]

Everyone has been paid, bug is fixed and there are no regressions. Great work everyone!

[Ollyws]

@muttmuure I think you may have forgot the bonus, we did get it merged within 24 hours.

[eVoloshchak]

@muttmuure I think you may have forgot the bonus, we did get it merged within 24 hours.

Same
By the way, what is the process with bonuses?
Who should track if C and C+ are eligible for bonuses? Contributor, Contributor+, or CME?

[muttmuure]

oops! Fixing that

[muttmuure]

It's up to me on the BugZero team to check. I just missed it this time.

[eVoloshchak]

It's up to me on the BugZero team to check. I just missed it this time.

Got it, thanks!

[muttmuure]

50% Bonus applied - again, thanks for the speedy work