Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Chat - In LHN preview there is no space between quoted text and normal text @thesahindia #11494

Closed
kbecciv opened this issue Oct 1, 2022 · 56 comments
Closed

[$250] Chat - In LHN preview there is no space between quoted text and normal text @thesahindia #11494

kbecciv opened this issue Oct 1, 2022 · 56 comments
Assignees
@rushatgabhane @isabelastisser @marcaaron @aldo-expensify
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Oct 1, 2022 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

  1. Navigate to any chat
  2. Type > quoted text
  3. Press shift + enter and type normal text
  4. Send
  5. Check the LHN if there's a space after quoted text
  6. Refresh and check again

Expected Result:

There should be a space in LHN

Actual Result:

The space goes away just after sending the message and gets added after refresh

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.10.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1282.mp4
Screen.Recording.2022-09-26.at.7.30.30.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664201097246429

View all open jobs on GitHub

Upwork Automation - Do Not Edit
@kbecciv kbecciv added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2022

Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Oct 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2022

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2022

@isabelastisser Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2022

@isabelastisser Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

@isabelastisser 10 days overdue. Is anyone even seeing these? Hello?

@isabelastisser
Copy link
Contributor

I was OOO for the past 3 weeks and catching up now, will review this soon.

@melvin-bot melvin-bot bot removed the Overdue label Oct 12, 2022
@isabelastisser isabelastisser added Weekly KSv2 and removed Daily KSv2 labels Oct 12, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@isabelastisser
Copy link
Contributor

Reviewing this now.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2022
@isabelastisser
Copy link
Contributor

I was able to reproduce it on the web and mobile.

bug.text.mp4

@isabelastisser isabelastisser added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Oct 23, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2022

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 23, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2022

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Chat - At LHN the space after quoted text goes away @thesahindia [$250] Chat - At LHN the space after quoted text goes away @thesahindia Oct 23, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2022
@marcaaron
Copy link
Contributor

@aldo-expensify can I assign you here? It looks like you're gonna make this change, but not sure. Let me know! 🙇

@aldo-expensify
Copy link
Contributor

@marcaaron yes!

@aldo-expensify aldo-expensify self-assigned this Nov 29, 2022
@madmax330 madmax330 removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 30, 2022
@isabelastisser
Copy link
Contributor

@aldo-expensify , there are no proposals and it looks like you're going to fix this, so can I remove the External label and add the Internal label instead?

@isabelastisser isabelastisser added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Nov 30, 2022
@aldo-expensify
Copy link
Contributor

Replaced @eVoloshchak by @rushatgabhane because he is assigned to the PR as C+ reviewer

@rushatgabhane rushatgabhane mentioned this issue Nov 30, 2022
Merged
98 tasks
@mollfpr mollfpr mentioned this issue Dec 1, 2022
Closed
@JmillsExpensify JmillsExpensify added the Reviewing Has a PR in review label Dec 1, 2022
@luacmartins
Copy link
Contributor

@isabelastisser can we compensate @mollfpr for their review on this PR?

@isabelastisser
Copy link
Contributor

External job post: https://www.upwork.com/jobs/~01536d6d9cdfac0456

Internal job post: https://www.upwork.com/ab/applicants/1599903806326996992/job-details

@mollfpr, I invited you to this job in Upwork, please accept it and I will hire you and issue the payment. Thanks!

@mollfpr
Copy link
Contributor

mollfpr commented Dec 5, 2022

@isabelastisser accepted, thanks!

@isabelastisser
Copy link
Contributor

@mollfpr paid! Thanks!

Closing this issue, all set!

@rushatgabhane
Copy link
Member

rushatgabhane commented Dec 6, 2022 •
edited
Loading

@isabelastisser could you please compensate me too for review of PR #12968

reference: #11494 (comment)

@thesahindia
Copy link
Member

@isabelastisser, it's also eligible for reporting compensation.

@aldo-expensify aldo-expensify reopened this Dec 8, 2022
@aldo-expensify
Copy link
Contributor

Reopening because there seem to be a pending payment

@isabelastisser
Copy link
Contributor

isabelastisser commented Dec 8, 2022 •
edited
Loading

Thanks for the heads up, @aldo-expensify! To clarify, are @rushatgabhane AND @thesahindia missing payment here?

@aldo-expensify
Copy link
Contributor

I know that @rushatgabhane is expected to be payed because he reviewed the PR #12968, I don't know about @thesahindia. @thesahindia are you waiting for payment too?

@thesahindia
Copy link
Member

@aldo-expensify, this is eligible for reporting compensation. I reported this.

@isabelastisser
Copy link
Contributor

isabelastisser commented Dec 10, 2022 •
edited
Loading

@rushatgabhane and @thesahindia, I extended the contract to you in Upwork; please apply, and I will issue the payment. Thanks!

@isabelastisser
Copy link
Contributor

@thesahindia paid!

@rushatgabhane please accept the offer and I will hire you and issue the payment in Upwork. Thanks!

@rushatgabhane
Copy link
Member

@isabelastisser applied, thank you!

@isabelastisser
Copy link
Contributor

@rushatgabhane paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rushatgabhane rushatgabhane

@isabelastisser isabelastisser

@marcaaron marcaaron

@aldo-expensify aldo-expensify

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests