Merge pull request #39389 from tienifr/fix/37296

fix scan expense report and transaction are not hidden
Expensify · Apr 12, 2024 · fb3e111 · fb3e111
2 parents c7d6926 + 276fd22
commit fb3e111
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/libs/SidebarUtils.ts b/src/libs/SidebarUtils.ts
@@ -93,9 +93,9 @@ function getOrderedReportIDs(
         );
         const isHidden = report.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN;
         const isFocused = report.reportID === currentReportId;
-        const hasErrors = Object.keys(OptionsListUtils.getAllReportErrors(report, reportActions) ?? {}).length !== 0;
-        const hasBrickError = hasErrors || doesReportHaveViolations ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
-        const shouldOverrideHidden = hasBrickError || isFocused || report.isPinned;
+        const allReportErrors = OptionsListUtils.getAllReportErrors(report, reportActions) ?? {};
+        const hasErrorsOtherThanFailedReceipt = doesReportHaveViolations || Object.values(allReportErrors).some((error) => error?.[0] !== 'report.genericSmartscanFailureMessage');
+        const shouldOverrideHidden = hasErrorsOtherThanFailedReceipt || isFocused || report.isPinned;
         if (isHidden && !shouldOverrideHidden) {
             return false;
         }