Merge pull request #42333 from bernhardoj/fix/42103-pdf-blinks

Fix pdf blinks when open it
Expensify · May 23, 2024 · d2e6445 · d2e6445
2 parents eda2f17 + c62bd40
commit d2e6445
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/src/components/PDFView/index.native.tsx b/src/components/PDFView/index.native.tsx
@@ -165,9 +165,10 @@ function PDFView({onToggleKeyboard, onLoadComplete, fileName, onPress, isFocused
         );
     }
 
-    return onPress && !successToLoadPDF ? (
+    return onPress ? (
         <PressableWithoutFeedback
             onPress={onPress}
+            fullDisabled={successToLoadPDF}
             style={[themeStyles.flex1, themeStyles.alignSelfStretch, !failedToLoadPDF && themeStyles.flexRow]}
             accessibilityRole={CONST.ACCESSIBILITY_ROLE.IMAGEBUTTON}
             // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

diff --git a/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx b/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx
@@ -35,6 +35,7 @@ function GenericPressable(
         onPressIn,
         onPressOut,
         accessible = true,
+        fullDisabled = false,
         ...rest
     }: PressableProps,
     ref: PressableRef,
@@ -136,6 +137,7 @@ function GenericPressable(
             hitSlop={shouldUseAutoHitSlop ? hitSlop : undefined}
             onLayout={shouldUseAutoHitSlop ? onLayout : undefined}
             ref={ref as ForwardedRef<View>}
+            disabled={fullDisabled}
             onPress={!isDisabled ? singleExecution(onPressHandler) : undefined}
             onLongPress={!isDisabled && onLongPress ? onLongPressHandler : undefined}
             onKeyDown={!isDisabled ? onKeyDown : undefined}

diff --git a/src/components/Pressable/GenericPressable/types.ts b/src/components/Pressable/GenericPressable/types.ts
@@ -137,6 +137,11 @@ type PressableProps = RNPressableProps &
 
         /** Turns off drag area for the component */
         noDragArea?: boolean;
+
+        /**
+         * Specifies if the pressable responder should be disabled
+         */
+        fullDisabled?: boolean;
     };
 
 type PressableRef = ForwardedRef<HTMLDivElement | View | RNText | undefined>;