Skip to content

Commit

Permalink
Merge pull request #21028 from Expensify/OSBotify-cherry-pick-staging…
Browse files Browse the repository at this point in the history
…-21023

🍒 Cherry pick PR #21023 to staging 🍒
  • Loading branch information
OSBotify authored Jun 19, 2023
2 parents 89dcd53 + cb3ff62 commit c6de102
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 12 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001032900
versionName "1.3.29-0"
versionCode 1001032901
versionName "1.3.29-1"
}

splits {
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.3.29.0</string>
<string>1.3.29.1</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.3.29.0</string>
<string>1.3.29.1</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.3.29-0",
"version": "1.3.29-1",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
12 changes: 7 additions & 5 deletions src/pages/workspace/WorkspaceMembersPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import withCurrentUserPersonalDetails from '../../components/withCurrentUserPers
import * as PolicyUtils from '../../libs/PolicyUtils';
import PressableWithFeedback from '../../components/Pressable/PressableWithFeedback';
import Log from '../../libs/Log';
import * as PersonalDetailsUtils from '../../libs/PersonalDetailsUtils';

const propTypes = {
/** The personal details of the person who is logged in */
Expand Down Expand Up @@ -286,8 +287,9 @@ class WorkspaceMembersPage extends React.Component {

validate() {
const errors = {};
const ownerAccountID = _.first(PersonalDetailsUtils.getAccountIDsByLogins([this.props.policy.owner]));
_.each(this.state.selectedEmployees, (member) => {
if (member !== this.props.policy.owner && member !== this.props.session.email) {
if (member !== ownerAccountID && member !== this.props.session.accountID) {
return;
}

Expand Down Expand Up @@ -319,7 +321,7 @@ class WorkspaceMembersPage extends React.Component {
* @returns {React.Component}
*/
renderItem({item}) {
const hasError = !_.isEmpty(item.errors) || this.state.errors[item.login];
const hasError = !_.isEmpty(item.errors) || this.state.errors[item.accountID];
const isChecked = _.contains(this.state.selectedEmployees, Number(item.accountID));
return (
<OfflineWithFeedback
Expand All @@ -328,7 +330,7 @@ class WorkspaceMembersPage extends React.Component {
errors={item.errors}
>
<PressableWithFeedback
style={[styles.peopleRow, (_.isEmpty(item.errors) || this.state.errors[item.login]) && styles.peopleRowBorderBottom, hasError && styles.borderColorDanger]}
style={[styles.peopleRow, (_.isEmpty(item.errors) || this.state.errors[item.accountID]) && styles.peopleRowBorderBottom, hasError && styles.borderColorDanger]}
onPress={() => this.toggleUser(item.accountID, item.pendingAction)}
accessibilityRole="checkbox"
accessibilityState={{
Expand Down Expand Up @@ -368,10 +370,10 @@ class WorkspaceMembersPage extends React.Component {
</View>
)}
</PressableWithFeedback>
{!_.isEmpty(this.state.errors[item.login]) && (
{!_.isEmpty(this.state.errors[item.accountID]) && (
<FormHelpMessage
isError
message={this.state.errors[item.login]}
message={this.state.errors[item.accountID]}
/>
)}
</OfflineWithFeedback>
Expand Down

0 comments on commit c6de102

Please sign in to comment.