Skip to content

Commit

Permalink
Add missing calls to App.confirmReadyToOpenApp
Browse files Browse the repository at this point in the history
  • Loading branch information
aldo-expensify committed Oct 18, 2024
1 parent d6f883a commit 5a1317a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/pages/settings/InitialSettingsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import * as UserUtils from '@libs/UserUtils';
import {hasGlobalWorkspaceSettingsRBR} from '@libs/WorkspacesSettingsUtils';
import * as ReportActionContextMenu from '@pages/home/report/ContextMenu/ReportActionContextMenu';
import variables from '@styles/variables';
import * as App from '@userActions/App';
import * as Link from '@userActions/Link';
import * as PaymentMethods from '@userActions/PaymentMethods';
import * as Session from '@userActions/Session';
Expand Down Expand Up @@ -102,6 +103,7 @@ function InitialSettingsPage({currentUserPersonalDetails}: InitialSettingsPagePr

useEffect(() => {
Wallet.openInitialSettingsPage();
App.confirmReadyToOpenApp();
}, []);

const toggleSignoutConfirmModal = (value: boolean) => {
Expand Down
5 changes: 5 additions & 0 deletions src/pages/workspace/WorkspaceInitialPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import useSingleExecution from '@hooks/useSingleExecution';
import useThemeStyles from '@hooks/useThemeStyles';
import useWaitForNavigation from '@hooks/useWaitForNavigation';
import {isConnectionInProgress} from '@libs/actions/connections';
import * as App from '@userActions/App';

Check failure on line 24 in src/pages/workspace/WorkspaceInitialPage.tsx

View workflow job for this annotation

GitHub Actions / ESLint check

Delete `App·from·'@userActions/App';⏎import·*·as·`

Check failure on line 24 in src/pages/workspace/WorkspaceInitialPage.tsx

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

Delete `App·from·'@userActions/App';⏎import·*·as·`
import * as CurrencyUtils from '@libs/CurrencyUtils';
import getTopmostRouteName from '@libs/Navigation/getTopmostRouteName';
import Navigation from '@libs/Navigation/Navigation';
Expand Down Expand Up @@ -178,6 +179,10 @@ function WorkspaceInitialPage({policyDraft, policy: policyProp, route}: Workspac
});
}, [policy, isOffline, policyFeatureStates, prevPendingFields]);

useEffect(() => {
App.confirmReadyToOpenApp();
}, []);

if (featureStates?.[CONST.POLICY.MORE_FEATURES.ARE_INVOICES_ENABLED]) {
const currencyCode = policy?.outputCurrency ?? CONST.CURRENCY.USD;

Expand Down

0 comments on commit 5a1317a

Please sign in to comment.