Merge pull request #49482 from ishpaul777/fix/bad-grammar

fixes optimistc case and delay submission current user bad grammar
Expensify · Sep 19, 2024 · 5491db3 · 5491db3
2 parents 98dc643 + 83f9fdf
commit 5491db3
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 10 deletions.
diff --git a/src/libs/NextStepUtils.ts b/src/libs/NextStepUtils.ts
@@ -38,14 +38,19 @@ Onyx.connect({
 function parseMessage(messages: Message[] | undefined) {
     let nextStepHTML = '';
 
-    messages?.forEach((part) => {
+    messages?.forEach((part, index) => {
         const isEmail = Str.isValidEmail(part.text);
         let tagType = part.type ?? 'span';
         let content = Str.safeEscape(part.text);
 
+        const previousPart = messages[index - 1];
+        const nextPart = messages[index + 1];
+
         if (currentUserEmail === part.text || part.clickToCopyText === currentUserEmail) {
             tagType = 'strong';
-            content = 'You';
+            content = nextPart?.text === `'s` ? 'Your' : 'You';
+        } else if (part.text === `'s` && (previousPart?.text === currentUserEmail || previousPart?.clickToCopyText === currentUserEmail)) {
+            content = '';
         } else if (isEmail) {
             tagType = 'next-step-email';
             content = EmailUtils.prefixMailSeparatorsWithBreakOpportunities(content);
@@ -116,6 +121,7 @@ function buildNextStep(report: OnyxEntry<Report>, predictedNextStatus: ValueOf<t
                     {
                         text: `${ownerDisplayName}`,
                         type: 'strong',
+                        clickToCopyText: ownerAccountID === currentUserAccountID ? currentUserEmail : '',
                     },
                     {
                         text: ' to ',
@@ -136,7 +142,12 @@ function buildNextStep(report: OnyxEntry<Report>, predictedNextStatus: ValueOf<t
                         text: 'Waiting for ',
                     },
                     {
-                        text: `${ownerDisplayName}'s`,
+                        text: `${ownerDisplayName}`,
+                        type: 'strong',
+                        clickToCopyText: ownerAccountID === currentUserAccountID ? currentUserEmail : '',
+                    },
+                    {
+                        text: `'s`,
                         type: 'strong',
                     },
                     {

diff --git a/tests/unit/NextStepUtilsTest.ts b/tests/unit/NextStepUtilsTest.ts
@@ -113,7 +113,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -143,7 +148,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -173,7 +183,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -203,7 +218,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -234,7 +254,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -267,7 +292,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {
@@ -298,7 +328,12 @@ describe('libs/NextStepUtils', () => {
                             text: 'Waiting for ',
                         },
                         {
-                            text: `${currentUserEmail}'s`,
+                            text: `${currentUserEmail}`,
+                            clickToCopyText: `${currentUserEmail}`,
+                            type: 'strong',
+                        },
+                        {
+                            text: "'s",
                             type: 'strong',
                         },
                         {