Skip to content

Commit

Permalink
Merge pull request #43823 from margelo/fix/sourcemaps-not-uploaded
Browse files Browse the repository at this point in the history
fix: CI upload source maps when deploying a new app version
  • Loading branch information
grgia authored Jun 17, 2024
2 parents 59e4f8b + 48d5f4e commit 2b8801e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/platformDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: android-sourcemap
path: android/app/build/generated/sourcemaps/react/release/*.map
path: android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map

- name: Upload Android version to GitHub artifacts
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
Expand Down
5 changes: 5 additions & 0 deletions ios/.xcode.env
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,8 @@
# For example, to use nvm with brew, add the following line
# . "$(brew --prefix nvm)/nvm.sh" --no-use
export NODE_BINARY=$(command -v node)

# Provide a sourcemap path so that in release builds a source map file will be
# created at the specified location.
# (RN's default behaviour on iOS is to skip creating a sourcemap file):
export SOURCEMAP_FILE="$(pwd)/../main.jsbundle.map";
2 changes: 1 addition & 1 deletion workflow_tests/assertions/platformDeployAssertions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function assertAndroidJobExecuted(workflowResult: Step[], didExecute = true, isP
steps.push(
createStepAssertion('Archive Android sourcemaps', true, null, 'ANDROID', 'Archiving Android sourcemaps', [
{key: 'name', value: 'android-sourcemap'},
{key: 'path', value: 'android/app/build/generated/sourcemaps/react/release/*.map'},
{key: 'path', value: 'android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map'},
]),
);
if (!isProduction) {
Expand Down

0 comments on commit 2b8801e

Please sign in to comment.