Merge pull request #7090 from Enragedsaturday/main

Remove didMount to stop auto focus on PasswordForm
Expensify · Jan 13, 2022 · 13b7b0b · 13b7b0b
2 parents a5fbe80 + 1417a78
commit 13b7b0b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/pages/signin/LoginForm.js b/src/pages/signin/LoginForm.js
@@ -58,7 +58,7 @@ class LoginForm extends React.Component {
     }
 
     componentDidMount() {
-        if (!canFocusInputOnScreenFocus() || !this.input) {
+        if (!canFocusInputOnScreenFocus() || !this.input || !this.props.isVisible) {
             return;
         }
         this.input.focus();

diff --git a/src/pages/signin/PasswordForm.js b/src/pages/signin/PasswordForm.js
@@ -18,6 +18,7 @@ import compose from '../../libs/compose';
 import TextInput from '../../components/TextInput';
 import * as ComponentUtils from '../../libs/ComponentUtils';
 import withToggleVisibilityView, {toggleVisibilityViewPropTypes} from '../../components/withToggleVisibilityView';
+import canFocusInputOnScreenFocus from '../../libs/canFocusInputOnScreenFocus';
 
 const propTypes = {
     /* Onyx Props */
@@ -55,7 +56,7 @@ class PasswordForm extends React.Component {
     }
 
     componentDidMount() {
-        if (!this.input) {
+        if (!canFocusInputOnScreenFocus() || !this.input || !this.props.isVisible) {
             return;
         }
         this.input.focus();