small_fixes_after_debugging. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javsanbel2
reviewed
Nov 30, 2023
javsanbel2
approved these changes
Nov 30, 2023
abhimanyugupta07
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment we've been having some slow 10min connection timeout requests, this PR was debugging this and resulted in some minor changes. The real root problems is related to AWS load balancer and TCP Keepalive timeouts, not related to WD code but to the deployment this PR addresses it: ExpediaGroup/apiary-federation#130
For future: Debugging did show that a call reporting 10mins spends all it's time in waiting for HMS call to respond, the overhead of WD in this is ms.