Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql dependency for apollo server upgrade #105

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

gky99
Copy link

@gky99 gky99 commented Feb 1, 2024

📝 Description

  • Upgrade graphql dependency for apollo server 3

🔗 Related Issues

@tlivings
Copy link
Collaborator

tlivings commented Feb 2, 2024

I am wondering if we can have a test that validates this runs ok in the Apollo version we are specifying. We have some code under examples, but no unit tests to validate these sorts of changes don't break anything.

@gky99
Copy link
Author

gky99 commented Feb 2, 2024

I am wondering if we can have a test that validates this runs ok in the Apollo version we are specifying. We have some code under examples, but no unit tests to validate these sorts of changes don't break anything.

According to the migration guide, there shouldn't be any change needed on graphql-comp side. This update is mainly to resolve the dependency conflict on catalyst-graphql-bootstrap. The test will happen on xp-api.
We can consider adding some unit tests when upgrading to v4, which requires changes in this package.

@tlivings tlivings merged commit f408d20 into ExpediaGroup:master Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants