Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: INT64 numbers are rounded for arrow.Array objects during json marshal process #128

Merged
merged 2 commits into from
Aug 17, 2024
Merged

fix: INT64 numbers are rounded for arrow.Array objects during json marshal process #128

merged 2 commits into from
Aug 17, 2024

Conversation

EXPEbdodla
Copy link
Collaborator

@EXPEbdodla EXPEbdodla commented Aug 14, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes

  1. arrow.Array implements JSON Marshaller. Arrow v8 version is rounding up the large numbers. Ex: -9223372036854775808 is rounded to -9223372036854776000. 9223372036854775807 is rounded to 9223372036854776000,9223372036854776000. Upgrading the Arrow to latest version resolved the issue. In the interest of time, I haven't debugged which version the issue is resolved and so on.
  2. Added test cases for this

@EXPEbdodla EXPEbdodla changed the title fix: Upgraded go arrow version to v17 fix: INT64 numbers are rounded for arrow.Array objects during json marshal process Aug 15, 2024
@EXPEbdodla EXPEbdodla changed the title fix: INT64 numbers are rounded for arrow.Array objects during json marshal process fix: INT64 numbers are rounded for arrow.Array objects during json marshal process Aug 15, 2024
acevedosharp
acevedosharp approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@acevedosharp acevedosharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Good on the upgrade, looks like v8 either had a reduced a 64 bit int range or uses a floating point representation.

@EXPEbdodla EXPEbdodla merged commit 4fd7b29 into master Aug 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acevedosharp acevedosharp acevedosharp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EXPEbdodla @acevedosharp