fix: Start up issues in Python Feature server with HTTP Registry #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXPEbdodla
force-pushed
the
python_feature_server_startup
branch
from
bdac770
to
d6d4d0d
Compare
acevedosharp
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes
Fixes the start up issues with Python Feature Server using HTTP Registry. HTTP Registry is throwing errors for the methods used in application start up. We don't need them in our use cases so it's not implemented. Returning empty response helps to fix the problem as a temporary work around.
Usage module is deleted by Feast. As we brought in new merges, we deleted that usage python module specific code from Expedia provider.