Feature/splunk configuration #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
January 8, 2025 16:25
earagon87
approved these changes
Jan 9, 2025
githubjianli
previously approved these changes
Jan 9, 2025
patduin
reviewed
Jan 10, 2025
templates/apiary-hms-readwrite.json
Outdated
| jsonencode({ | ||
| "splunk-token": "${splunk_hec_token}", | ||
| "splunk-url": "${splunk_hec_host}", | ||
| "splunk-source": "apiary-hms-readonly-logs", |
patduin
reviewed
Jan 10, 2025
| "logDriver": "awslogs", | ||
| "options": { | ||
| "logConfiguration": { | ||
| "logDriver": "${enable_splunk_logging ? "splunk" : "awslogs"}", |
There was a problem hiding this comment.
not a blocker but for future consider setting:
"logDriver" : "${hmsReadOnlyLogDriver}"
"option" : "${hmsReadOnlyLogOptions}" --> This needs to be jsonencoded somehow but I think that's possible.
Then we avoid the ifs and we can also introduce additional logging solutions.
patduin
requested changes
Jan 10, 2025
patduin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled Splunk for log forwarding and implemented health checks for ECS HMS.