Feature/s3 tag policies #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroark-exp
reviewed
Jun 22, 2021
| @@ -59,6 +59,10 @@ module "apiary" { | |||
| } | |||
| ] | |||
| apiary_customer_accounts = ["aws_account_no_1", "aws_account_no_2"] | |||
| apiary_customer_condition = <<EOF | |||
| "ForAnyValue:StringEquals": {"s3:ExistingObjectTag/security": [ "public"] } , | |||
| "StringLike": {"s3:ExistingObjectTag/type": "image*" } | |||
There was a problem hiding this comment.
I have it as 'OBJECT_TYPE' in my code, but I'll change it to 'type'
There was a problem hiding this comment.
variable is generic, we can use OBJECT_TYPE internally, above is just a example to show usage
There was a problem hiding this comment.
Oh this is in the README, didn't notice...
mroark-exp
previously approved these changes
Jun 22, 2021
Dima1224
approved these changes
Jun 22, 2021
mroark-exp
approved these changes
Jun 22, 2021
barnharts4
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added apiary_consumer_iamroles variable to grant cross account access to IAM roles
Added apiary_customer_condition variable to restrict access using S3 object tags
🔗 Related Issues