Feature/s3 object ownership #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenFigueiredo
previously approved these changes
Oct 30, 2020
barnharts4
reviewed
Oct 30, 2020
| object_ownership = "BucketOwnerPreferred" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we also do this for our internal buckets like inventory, logs, etc? Especially for inventory bucket, this would allow us to federate the inventory tables if we ever decide we want to.
Although looking at the docs closer, it would rely on Amazon inventory process writing files with bucket-owner-full-control ACL for the object to get correct AWS owner. Maybe we can set it in the hopes that AWS either does use that ACL, or will in the future.
There was a problem hiding this comment.
done for inventory bucket, other bucket should be written from same accounts
barnharts4
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Add aws_s3_bucket_ownership_controls terraform resource for all apiary managed buckets,cross account object writes will be owned by bucket instead of writer.
🔗 Related Issues