Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 169 #170

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Issue 169 #170

merged 6 commits into from
Aug 12, 2020

Conversation

mroark1m
Copy link
Contributor

📝 Description

🔗 Related Issues

@@ -12,6 +12,7 @@
"Action": [
"s3:GetBucketLocation",
"s3:GetObject",
"s3:GetBucketAcl",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to allow this for customer_principals, seems like we should allow it further down for producer_iamroles too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that. I couldn't decide since the specific tool we are doing this for isn't planned to be a producer, but I will add that.

Copy link
Contributor Author

@mroark1m mroark1m Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that now, please review again @barnharts4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add s3:GetObjectAcl ?

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [?.?.?] - ????-??-??
### Fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a 6.4.3 to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the workflow for releasing, but I went ahead and changed the date to today and put 6.4.3 in the version number here. Hope that's right.

@mroark1m mroark1m requested a review from barnharts4 August 12, 2020 17:06
@mroark1m mroark1m merged commit 0fd4512 into master Aug 12, 2020
@mroark1m mroark1m deleted the issue-169 branch August 12, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants