-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 169 #170
Conversation
@@ -12,6 +12,7 @@ | |||
"Action": [ | |||
"s3:GetBucketLocation", | |||
"s3:GetObject", | |||
"s3:GetBucketAcl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are going to allow this for customer_principals
, seems like we should allow it further down for producer_iamroles
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with that. I couldn't decide since the specific tool we are doing this for isn't planned to be a producer, but I will add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that now, please review again @barnharts4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add s3:GetObjectAcl
?
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file. | |||
|
|||
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|||
## [?.?.?] - ????-??-?? | |||
### Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a 6.4.3
to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the workflow for releasing, but I went ahead and changed the date to today and put 6.4.3 in the version number here. Hope that's right.
📝 Description
🔗 Related Issues