adding keys extractors module #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilra
reviewed
Aug 20, 2020
...-extractor/src/main/java/com/expedia/www/haystack/pipes/commons/key/extractor/Constants.java
Outdated
Show resolved
Hide resolved
kapilra
reviewed
Aug 23, 2020
...rs/src/main/java/com/expedia/www/haystack/pipes/kafkaProducer/extractor/SampleExtractor.java
Outdated
Show resolved
Hide resolved
kapilra
reviewed
Aug 23, 2020
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
This module shouldn't have any config
There was a problem hiding this comment.
true! I got the idea, have moved it to kafka producer module
kapilra
reviewed
Aug 23, 2020
...tor/src/main/java/com/expedia/www/haystack/pipes/commons/key/extractor/SpanKeyExtractor.java
Outdated
Show resolved
Hide resolved
kapilra
reviewed
Aug 23, 2020
...java/com/expedia/www/haystack/pipes/commons/key/extractor/loader/SpanKeyExtractorLoader.java
Outdated
Show resolved
Hide resolved
kapilra
reviewed
Aug 25, 2020
kapilra
reviewed
Aug 25, 2020
kapilra
reviewed
Aug 25, 2020
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| public class SampleExtractor implements SpanKeyExtractor { |
There was a problem hiding this comment.
Use this for default behaviour of writing whole span as json
There was a problem hiding this comment.
this change will be done in coming PR
kapilra
reviewed
Aug 25, 2020
kapilra
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.