fix: we are sure about type if parent checked it #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type delta calculation here is needed for discriminator to be sure that we can compile.
kklash
approved these changes
Jan 26, 2024
This was referenced Jan 26, 2024
|
is there a breaking unit test we can add for this case? (a part of the test case Konnor added in the issue?) |
ChALkeR
added a commit
that referenced
this pull request
Jan 27, 2024
|
@mvayngrib done. #179 will improve it once this lands. Upd: I'll update the testcase. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
|
ChALkeR
added a commit
that referenced
this pull request
Jan 27, 2024
ChALkeR
force-pushed
the
chalker/fix-discriminator-typecheck/0
branch
from
731e2c6
to
75dd90b
Compare
mvayngrib
previously approved these changes
Jan 29, 2024
ChALkeR
force-pushed
the
chalker/fix-discriminator-typecheck/0
branch
from
75dd90b
to
c87a7cc
Compare
mvayngrib
approved these changes
Jan 29, 2024
|
This needs a second review per the new process. |
|
@kklash one more time please 😅. We're trying out a more strict review process. I'm already not a fan |
kklash
approved these changes
Jan 31, 2024
kklash
approved these changes
Jan 31, 2024
|
@ChALkeR this good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type delta calculation here is needed for discriminator to be sure that we can compile.
Fixes: #176.
This is just the first part of the fix that will work if
type: objectis specified on levels 1 and 2 or level 3.An additional fix is needed to allow specifying
type: objectonly once on level 1.See also explanation in #176 (comment)