feat(ci): add forge fmt and solhint jobs

.github/workflows/fmt.yml

@@ -0,0 +1,56 @@
+name: Format using `forge fmt`
+
+on: 
+  pull_request:
+  push:
+    branches:
+      - main
+      - release/**
+    tags:
+      - "*"
+
+env:
+  FOUNDRY_PROFILE: ci
+
+jobs:
+  check:
+    strategy:
+      fail-fast: true
+
+    name: Foundry project
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: recursive
+
+      - name: Install Foundry
+        uses: foundry-rs/foundry-toolchain@v1
+        with:
+          # replace nightly because latest nightly release has some breaking changes that result in test failures
+          # this is a previous recent nightly release that should work
+          version: nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9
+
+      - name: Run Forge build
+        run: |
+          forge --version
+          forge build --sizes
+        id: build
+
+      - name: Run Forge Formatter
+        run: |
+          forge fmt --check
+        id: fmt
+
+      - name: Add comment on failure
+        if: failure()
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 'The code is not formatted correctly. Please run `forge fmt` and push the changes.'
+            })

.github/workflows/lint.yml

@@ -0,0 +1,45 @@
+name: Run `solhint` linter
+
+on: 
+  pull_request:
+  push:
+    branches:
+      - main
+      - release/**
+    tags:
+      - "*"
+
+jobs:
+  check:
+    strategy:
+      fail-fast: true
+
+    name: Foundry project
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v2
+        with:
+          node-version: '22'
+
+      - name: Install Solhint
+        run: npm install --save-dev solhint
+
+      - name: Run Solhint
+        run: |
+          npx solhint 'src/**/*.sol' -c ./src/.solhint.json
+
+      - name: Add comment on failure
+        if: failure()
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: 'Linting failed. Please check the logs.'
+            })

.github/workflows/test.yml

@@ -52,5 +52,5 @@ jobs:
               issue_number: context.issue.number,
               owner: context.repo.owner,
               repo: context.repo.repo,
-              body: 'The GitHub Actions workflow has failed. Please check the logs for more details.'
+              body: 'The tests have failed. Please check the logs for more details.'
             })

.solhintignore

@@ -0,0 +1 @@
+src/lzApp/*.sol

script/10_DeployExocoreGatewayOnly.s.sol

@@ -3,14 +3,14 @@ pragma solidity ^0.8.19;
 import {ILayerZeroEndpointV2} from "@layerzero-v2/protocol/contracts/interfaces/ILayerZeroEndpointV2.sol";
 
 import {ProxyAdmin} from "@openzeppelin-contracts/contracts/proxy/transparent/ProxyAdmin.sol";
-import {TransparentUpgradeableProxy} from "@openzeppelin-contracts/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
+import {TransparentUpgradeableProxy} from
+    "@openzeppelin-contracts/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
 
 import {ExocoreGateway} from "../src/core/ExocoreGateway.sol";
 import "forge-std/Script.sol";
 import {BaseScript} from "./BaseScript.sol";
 
 contract DeployExocoreGatewayOnly is BaseScript {
-
     function setUp() public virtual override {
         // load keys
         super.setUp();
@@ -35,8 +35,7 @@ contract DeployExocoreGatewayOnly is BaseScript {
                         address(exocoreGatewayLogic),
                         address(exocoreProxyAdmin),
                         abi.encodeWithSelector(
-                            exocoreGatewayLogic.initialize.selector,
-                            payable(exocoreValidatorSet.addr)
+                            exocoreGatewayLogic.initialize.selector, payable(exocoreValidatorSet.addr)
                         )
                     )
                 )
@@ -52,10 +51,8 @@ contract DeployExocoreGatewayOnly is BaseScript {
             vm.serializeAddress(exocoreContracts, "exocoreGateway", address(exocoreGateway));
 
         string memory deployedContracts = "deployedContracts";
-        string memory finalJson =
-            vm.serializeString(deployedContracts, "exocore", exocoreContractsOutput);
+        string memory finalJson = vm.serializeString(deployedContracts, "exocore", exocoreContractsOutput);
 
         vm.writeJson(finalJson, "script/deployedExocoreGatewayOnly.json");
-
     }
-}
+}

script/11_SetPeers.s.sol

@@ -50,8 +50,7 @@ contract SetPeersAndUpgrade is BaseScript {
         uint256 i = 0;
         uint256 tries = 5;
         bool success;
-        while(i < tries) {
-
+        while (i < tries) {
             vm.selectFork(exocore);
             success = gateway.peers(clientChainId) == bootstrapAddr.toBytes32();
 
@@ -90,8 +89,8 @@ contract SetPeersAndUpgrade is BaseScript {
         console.log(
             "source .env && cast send --rpc-url $EXOCORE_TESETNET_RPC",
             exocoreGatewayAddr,
-            "\"markBootstrapOnAllChains()\"",
+            '"markBootstrapOnAllChains()"',
             "--private-key $TEST_ACCOUNT_THREE_PRIVATE_KEY"
         );
     }
-}
+}

script/12_RedeployClientChainGateway.s.sol

@@ -1,6 +1,7 @@
 pragma solidity ^0.8.19;
 
-import {TransparentUpgradeableProxy} from "@openzeppelin-contracts/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
+import {TransparentUpgradeableProxy} from
+    "@openzeppelin-contracts/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
 import {UpgradeableBeacon} from "@openzeppelin-contracts/contracts/proxy/beacon/UpgradeableBeacon.sol";
 
 import {Bootstrap} from "../src/core/Bootstrap.sol";
@@ -24,29 +25,19 @@ contract RedeployClientChainGateway is BaseScript {
         super.setUp();
         // load contracts
         string memory prerequisiteContracts = vm.readFile("script/deployedBootstrapOnly.json");
-        clientChainLzEndpoint = ILayerZeroEndpointV2(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.lzEndpoint")
-        );
+        clientChainLzEndpoint =
+            ILayerZeroEndpointV2(stdJson.readAddress(prerequisiteContracts, ".clientChain.lzEndpoint"));
         require(address(clientChainLzEndpoint) != address(0), "client chain l0 endpoint should not be empty");
-        beaconOracle = EigenLayerBeaconOracle(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.beaconOracle")
-        );
+        beaconOracle = EigenLayerBeaconOracle(stdJson.readAddress(prerequisiteContracts, ".clientChain.beaconOracle"));
         require(address(beaconOracle) != address(0), "beacon oracle should not be empty");
-        vaultBeacon = UpgradeableBeacon(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.vaultBeacon")
-        );
+        vaultBeacon = UpgradeableBeacon(stdJson.readAddress(prerequisiteContracts, ".clientChain.vaultBeacon"));
         require(address(vaultBeacon) != address(0), "vault beacon should not be empty");
-        capsuleBeacon = UpgradeableBeacon(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.capsuleBeacon")
-        );
+        capsuleBeacon = UpgradeableBeacon(stdJson.readAddress(prerequisiteContracts, ".clientChain.capsuleBeacon"));
         require(address(capsuleBeacon) != address(0), "capsule beacon should not be empty");
-        beaconProxyBytecode = BeaconProxyBytecode(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.beaconProxyBytecode")
-        );
+        beaconProxyBytecode =
+            BeaconProxyBytecode(stdJson.readAddress(prerequisiteContracts, ".clientChain.beaconProxyBytecode"));
         require(address(beaconProxyBytecode) != address(0), "beacon proxy bytecode should not be empty");
-        bootstrap = Bootstrap(
-            stdJson.readAddress(prerequisiteContracts, ".clientChain.bootstrap")
-        );
+        bootstrap = Bootstrap(stdJson.readAddress(prerequisiteContracts, ".clientChain.bootstrap"));
         require(address(bootstrap) != address(0), "bootstrap should not be empty");
         clientChain = vm.createSelectFork(clientChainRPCURL);
     }
@@ -64,25 +55,18 @@ contract RedeployClientChainGateway is BaseScript {
         );
         // then the client chain initialization
         address[] memory emptyList;
-        bytes memory initialization = abi.encodeWithSelector(
-            clientGatewayLogic.initialize.selector,
-            exocoreValidatorSet.addr,
-            emptyList
-        );
-        bootstrap.setClientChainGatewayLogic(
-            address(clientGatewayLogic),
-            initialization
-        );
+        bytes memory initialization =
+            abi.encodeWithSelector(clientGatewayLogic.initialize.selector, exocoreValidatorSet.addr, emptyList);
+        bootstrap.setClientChainGatewayLogic(address(clientGatewayLogic), initialization);
         vm.stopBroadcast();
 
         string memory clientChainContracts = "clientChainContracts";
         string memory clientChainContractsOutput =
             vm.serializeAddress(clientChainContracts, "clientGatewayLogic", address(clientGatewayLogic));
 
         string memory deployedContracts = "deployedContracts";
-        string memory finalJson =
-            vm.serializeString(deployedContracts, "clientChain", clientChainContractsOutput);
+        string memory finalJson = vm.serializeString(deployedContracts, "clientChain", clientChainContractsOutput);
 
         vm.writeJson(finalJson, "script/redeployClientChainGateway.json");
     }
-}
+}

script/2_DeployBoth.s.sol

@@ -58,7 +58,7 @@ contract DeployScript is BaseScript {
 
         // deploy beacon chain oracle
         beaconOracle = _deployBeaconOracle();
-        
+
         /// deploy vault implementation contract and capsule implementation contract
         /// that has logics called by proxy
         vaultImplementation = new Vault();
@@ -90,9 +90,7 @@ contract DeployScript is BaseScript {
                         address(clientGatewayLogic),
                         address(clientChainProxyAdmin),
                         abi.encodeWithSelector(
-                            clientGatewayLogic.initialize.selector,
-                            payable(exocoreValidatorSet.addr),
-                            whitelistTokens
+                            clientGatewayLogic.initialize.selector, payable(exocoreValidatorSet.addr), whitelistTokens
                         )
                     )
                 )