Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(btc-staking): UTXOGateway and BTC staking test #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(btc-staking): UTXOGateway and BTC staking test #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ node_modules
.secrets

script/integration/*.json
yarn-error.log
16 changes: 11 additions & 5 deletions hardhat.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require("dotenv").config();
/** @type import('hardhat/config').HardhatUserConfig */
module.exports = {
solidity: {
version: "0.8.19",
version: "0.8.22",
settings: {
optimizer: {
enabled: true,
Expand All @@ -17,12 +17,18 @@ module.exports = {
networks: {
hardhat: {
},
exocore_testnet: {
exocore_localnet: {
chainId: 9000,
url: "http://23.162.56.84:8545",
url: "http://127.0.0.1:8545",
chainId: 233,
Comment on lines 21 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove duplicate chainId property

The chainId is defined twice with different values (9000 and 233). This could lead to confusion or unexpected behavior.

  exocore_localnet: {
-     chainId: 9000,
      url: "http://127.0.0.1:8545",
      chainId: 233,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
chainId: 9000,
url: "http://23.162.56.84:8545",
url: "http://127.0.0.1:8545",
chainId: 233,
url: "http://127.0.0.1:8545",
chainId: 233,
🧰 Tools
🪛 Biome (1.9.4)

[error] 21-21: This property value named chainId is later overwritten by an object member with the same name.

Overwritten with this value.

If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored.
Unsafe fix: Remove this property value named chainId

(lint/suspicious/noDuplicateObjectKeys)

accounts: [
// process.env.EXOCORE_DEPLOYER_PRIVATE_KEY,
// process.env.EXOCORE_VALIDATOR_SET_PRIVATE_KEY
process.env.LOCAL_EXOCORE_FUNDED_ACCOUNT_PRIVATE_KEY,
process.env.TEST_ACCOUNT_ONE_PRIVATE_KEY,
process.env.TEST_ACCOUNT_TWO_PRIVATE_KEY,
process.env.TEST_ACCOUNT_THREE_PRIVATE_KEY,
process.env.TEST_ACCOUNT_FOUR_PRIVATE_KEY,
process.env.TEST_ACCOUNT_FIVE_PRIVATE_KEY,
process.env.TEST_ACCOUNT_SIX_PRIVATE_KEY,
]
}
}
Expand Down
Loading
Loading