Fix/native restaking withdraw #10

wewecalibrate · 2024-05-31T01:57:54Z

Native restaking withdraw flow implemented

Summary by CodeRabbit

New Features
- Introduced new events and functions in ExoCapsule for withdrawal actions, restaking activation, and ETH handling outside the Beacon Chain.
Bug Fixes
- Enhanced error handling in ExoCapsule to improve withdrawal process reliability.
Refactor
- Updated NativeRestakingController to handle both partial and full withdrawals with new proof types.
- Renamed and restructured contracts and functions in tests to better reflect their purposes and improve clarity.
Chores
- Removed the unused GWEI_TO_WEI constant from ClientChainGatewayStorage to clean up the codebase.

…eway

…l merkle proof

github-actions · 2024-07-15T15:50:03Z

Linting failed. Please check the logs.

github-actions · 2024-07-15T15:52:27Z

The build has failed. Please check the logs.

github-actions · 2024-07-15T15:54:57Z

Linting failed. Please check the logs.

github-actions · 2024-07-15T15:57:28Z

The build has failed. Please check the logs.

coderabbitai

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8e27ced and 260f6de.

Files selected for processing (1)

src/core/ExoCapsule.sol (7 hunks)

Additional context used

GitHub Check: Foundry project

src/core/ExoCapsule.sol

[failure] 282-282:
Variable "withdrawalTimestamp" is unused

Additional comments not posted (15)

src/core/ExoCapsule.sol (15)

25-28: Event Addition Approved: PartialWithdrawalRedeemed

The PartialWithdrawalRedeemed event is correctly added and follows Solidity event naming conventions.

30-32: Event Addition Approved: FullWithdrawalRedeemed

The FullWithdrawalRedeemed event is correctly added and follows Solidity event naming conventions.

34-34: Event Addition Approved: RestakingActivated

The RestakingActivated event is correctly added and follows Solidity event naming conventions.

36-36: Event Addition Approved: NonBeaconChainETHReceived

The NonBeaconChainETHReceived event is correctly added and follows Solidity event naming conventions.

38-38: Event Addition Approved: NonBeaconChainETHWithdrawn

The NonBeaconChainETHWithdrawn event is correctly added and follows Solidity event naming conventions.

42-42: Error Addition Approved: InvalidHistoricalSummaries

The InvalidHistoricalSummaries error is correctly added and follows Solidity error naming conventions.

45-45: Error Addition Approved: WithdrawalAlreadyProven

The WithdrawalAlreadyProven error is correctly added and follows Solidity error naming conventions.

68-71: Function Addition Approved: receive

The receive function is correctly added and handles receiving ETH properly.

Line range hint 72-82:
Function Changes Approved: initialize

The initialize function correctly sets up the contract. The emission of the RestakingActivated event is intentional and aligns with the design.

Line range hint 88-128:
Function Changes Approved: verifyDepositProof

The verifyDepositProof function includes necessary checks and updates to verify deposit proofs correctly.

181-186: Function Changes Approved: withdraw

The withdraw function includes necessary checks and updates to handle withdrawals correctly.

190-200: Function Addition Approved: withdrawNonBeaconChainETHBalance

The withdrawNonBeaconChainETHBalance function includes necessary checks and updates to handle non-Beacon Chain ETH withdrawals correctly.

251-256: Function Changes Approved: _sendETH

The _sendETH function includes necessary checks and updates to handle ETH transfers correctly.

296-298: Function Changes Approved: _isActivatedAtEpoch

The _isActivatedAtEpoch function includes necessary checks and updates to verify activation epochs correctly.

Line range hint 300-302:
Function Changes Approved: _isStaleProof

The _isStaleProof function includes necessary checks and updates to verify stale proofs correctly.

src/core/ExoCapsule.sol

github-actions · 2024-07-15T16:06:46Z

Linting failed. Please check the logs.

github-actions · 2024-07-15T16:09:35Z

The build has failed. Please check the logs.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 260f6de and cc41593.

Files selected for processing (5)

src/core/ExoCapsule.sol (7 hunks)
src/libraries/BeaconChainProofs.sol (6 hunks)
test/foundry/DepositWithdrawPrinciple.t.sol (8 hunks)
test/foundry/ExocoreDeployer.t.sol (6 hunks)
test/foundry/unit/ExoCapsule.t.sol (5 hunks)

Files skipped from review as they are similar to previous changes (5)

src/core/ExoCapsule.sol
src/libraries/BeaconChainProofs.sol
test/foundry/DepositWithdrawPrinciple.t.sol
test/foundry/ExocoreDeployer.t.sol
test/foundry/unit/ExoCapsule.t.sol

github-actions · 2024-07-16T02:11:39Z

The tests have failed. Please check the logs.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cc41593 and 806c749.

Files selected for processing (2)

src/core/NativeRestakingController.sol (3 hunks)
test/foundry/DepositWithdrawPrinciple.t.sol (9 hunks)

Files skipped from review as they are similar to previous changes (2)

src/core/NativeRestakingController.sol
test/foundry/DepositWithdrawPrinciple.t.sol

coderabbitai

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)

src/storage/ClientChainGatewayStorage.sol (2)
Line range hint 59-75: Review of Constructor: Ensure robustness and validate parameters.

The constructor initializes several immutable state variables and performs checks to ensure that the addresses are not zero. This is a good practice as it prevents the contract from being deployed with invalid configuration.

However, it would be beneficial to add more detailed error messages to the require statements to aid debugging and provide clearer context in case of deployment failures.
-        require(
-            beaconOracleAddress_ != address(0),
-            "ClientChainGatewayStorage: beacon chain oracle address should not be empty"
-        );
-        require(
-            exoCapsuleBeacon_ != address(0),
-            "ClientChainGatewayStorage: the exoCapsuleBeacon address for beacon proxy should not be empty"
-        );
+        require(beaconOracleAddress_ != address(0), "ClientChainGatewayStorage: Invalid beaconOracleAddress");
+        require(exoCapsuleBeacon_ != address(0), "ClientChainGatewayStorage: Invalid exoCapsuleBeacon");
Line range hint 79-87: Review of _getCapsule Function: Optimize error handling.

The function _getCapsule retrieves a capsule based on the owner address and reverts if the capsule does not exist. This is a critical function as it directly interacts with potentially sensitive data.

Consider enhancing the error message in the revert statement to include the owner address. This would provide better traceability and debugging information.
-        if (address(capsule) == address(0)) {
-            revert CapsuleNotExist();
-        }
+        if (address(capsule) == address(0)) {
+            revert CapsuleNotExist({
+                owner: owner
+            });
+        }

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 806c749 and 9426325.

Files selected for processing (1)

src/storage/ClientChainGatewayStorage.sol (1 hunks)

src/core/ExoCapsule.sol

wewecalibrate · 2024-07-17T02:45:04Z

@MaxMustermann2 we don't need it here because, there are 4 _sendETH and we're only sending to capsuleOwner in the withdraw. So we don't need to check again because capsuleOwner is not address(0).
And regarding withdrawNonBeaconETH and withraw available ETH, we only need to check which is done in the external function.

bwhour

it looks good.

adu-web3

Overall the withdrawal verification logics look good to me, but I think the underlying check is critical and should not be missing

src/core/ExoCapsule.sol

src/libraries/BeaconChainProofs.sol

adu-web3 and others added 30 commits May 13, 2024 14:31

initialize ExocoreCapsule

9d71017

add ValidatorContainer library

e440d18

implement capsule deposit

d4b6d5b

initiate updateStakingBalance

b904a61

add index=>pubkey mapping

12eb183

add withdrawal container and integrate exocapsule into clientchaingat…

c73d017

…eway

add isValidWithdrawalContainerRoot implementation to verify withdrawa…

e11feb4

…l merkle proof

add NativeRestakingController contract

0d1fa3d

add createExoCapsule function

2e11c2b

add depositBeaconChainValidator implementation

5ff831c

abstract CommonRestakingController

92f7dd6

add whenNotPaused modifier to functions

c201ee1

rename CommonRestakingController as BaseRestakingController

c6b241b

remove unused imports and fix errors

973a8e8

fix operator address length

a5e8b3f

optimize some code with DRY princple

44f3e63

update log and reuse some code

b18324e

fix test

68b7505

move stake interface to NativeRestakingController

bbb4527

update principleBalance upon receiving deposit response

e2d1b34

draft plantuml diagram

dd99dd7

fix depositBeaconChainValidator diagram

9d87ca4

fix container merklizatiion function

aeb5e69

forge install: eigenlayer-beacon-oracle

8fc724f

integrate EigenLayerBeaconOracle into ExoCapsule

c6e459c

add uint test for ExoCapsule.verifyDepositProof

8404a42

Optimize reuse code

30103b8

add other uint tests for ExoCapsule.verifyDepositProof

db30157

adapt to use beacon proxies and create2 for vaults and capsules creation

e1ca5bd

add nativedepositwithdraw integration test

52b894d

fix: update reentrancy guard import

260f6de

coderabbitai bot reviewed Jul 15, 2024

View reviewed changes

src/core/ExoCapsule.sol Outdated Show resolved Hide resolved

src/core/ExoCapsule.sol Outdated Show resolved Hide resolved

fix: add more constants for beaconchain proofs

8b3634c

feat: beacon chain proof verification updated

cc41593

coderabbitai bot reviewed Jul 16, 2024

View reviewed changes

fix: integration test with 32 ether deposit cap

806c749

coderabbitai bot reviewed Jul 16, 2024

View reviewed changes

fix: remove unused variable for slither check

9426325

coderabbitai bot reviewed Jul 16, 2024

View reviewed changes

fix: ignore slither for withdraw eth to recipient address

be519f2

wewecalibrate requested a review from MaxMustermann2 July 16, 2024 13:44

MaxMustermann2 approved these changes Jul 16, 2024

View reviewed changes

src/core/ExoCapsule.sol Show resolved Hide resolved

src/core/ExoCapsule.sol Show resolved Hide resolved

src/core/ExoCapsule.sol Show resolved Hide resolved

src/core/ExoCapsule.sol Show resolved Hide resolved

bwhour approved these changes Jul 17, 2024

View reviewed changes

adu-web3 reviewed Jul 17, 2024

View reviewed changes

ExocoreNetwork deleted a comment from coderabbitai bot Jul 17, 2024

wewecalibrate merged commit 51e4969 into main Jul 17, 2024
6 checks passed

wewecalibrate mentioned this pull request Jul 17, 2024

Revert "Fix/native restaking withdraw" #51

Closed

cloud8little deleted the fix/native-restaking-withdraw-in-progress branch July 23, 2024 03:16

coderabbitai bot mentioned this pull request Sep 19, 2024

refactor: separate NST deposit/withdrawal from LST deposit/withdrawal #96

Merged

6 tasks

coderabbitai bot mentioned this pull request Oct 10, 2024

Add Upgrade ExoCapsule and WithdrawalValidator Script #108

Merged

This was referenced Nov 14, 2024

feat(generate): native restaking genesis #123

Merged

fix: use the validatorID instead of pubkey #124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/native restaking withdraw #10

Fix/native restaking withdraw #10

wewecalibrate commented May 31, 2024 •

edited by coderabbitai bot

Loading

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

coderabbitai bot left a comment

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

coderabbitai bot left a comment

github-actions bot commented Jul 16, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

wewecalibrate commented Jul 17, 2024

bwhour left a comment

adu-web3 left a comment

Fix/native restaking withdraw #10

Fix/native restaking withdraw #10

Conversation

wewecalibrate commented May 31, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 15, 2024

github-actions bot commented Jul 15, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 16, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

wewecalibrate commented Jul 17, 2024

bwhour left a comment

Choose a reason for hiding this comment

adu-web3 left a comment

Choose a reason for hiding this comment

wewecalibrate commented May 31, 2024 •

edited by coderabbitai bot

Loading