refactor: update error message

ExocoreNetwork · Oct 14, 2024 · 897a085 · 897a085
1 parent a1c6aa7
commit 897a085
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/core/CombinedFaucet.sol b/src/core/CombinedFaucet.sol
@@ -66,7 +66,10 @@ contract CombinedFaucet is
 
     function _withdraw(address dst) internal {
         if (lastRequestTime[dst] != 0) {
-            require(block.timestamp >= lastRequestTime[dst] + ONE_DAY, "CombinedFaucet: 24h rate limit breached");
+            require(
+                block.timestamp >= lastRequestTime[dst] + ONE_DAY,
+                "CombinedFaucet: Rate limit exceeded. Please wait 24 hours."
+            );
         }
         lastRequestTime[dst] = block.timestamp;
         if (token != address(0)) {

diff --git a/test/foundry/unit/CombinedFaucet.t.sol b/test/foundry/unit/CombinedFaucet.t.sol
@@ -73,7 +73,7 @@ contract ERC20FaucetTest is BaseFaucetTest {
         assertEq(token.balanceOf(address(faucet)), tokenAmount * 4);
 
         // Ensure 24h rate limit is enforced
-        vm.expectRevert("CombinedFaucet: 24h rate limit breached");
+        vm.expectRevert("CombinedFaucet: Rate limit exceeded. Please wait 24 hours.");
         vm.prank(user1);
         faucet.requestTokens();
     }
@@ -84,7 +84,7 @@ contract ERC20FaucetTest is BaseFaucetTest {
         faucet.requestTokens();
 
         // Try again before 24 hours have passed
-        vm.expectRevert("CombinedFaucet: 24h rate limit breached");
+        vm.expectRevert("CombinedFaucet: Rate limit exceeded. Please wait 24 hours.");
         vm.prank(user1);
         faucet.requestTokens();
 
@@ -200,7 +200,7 @@ contract NativeTokenFaucetTest is BaseFaucetTest {
         assertEq(address(faucet).balance, tokenAmount * 4);
 
         // Ensure 24h rate limit is enforced
-        vm.expectRevert("CombinedFaucet: 24h rate limit breached");
+        vm.expectRevert("CombinedFaucet: Rate limit exceeded. Please wait 24 hours.");
         vm.prank(owner);
         faucet.withdraw(user1);
     }
@@ -230,14 +230,14 @@ contract NativeTokenFaucetTest is BaseFaucetTest {
         faucet.withdraw(user1);
 
         // Try again before 24 hours have passed
-        vm.expectRevert("CombinedFaucet: 24h rate limit breached");
+        vm.expectRevert("CombinedFaucet: Rate limit exceeded. Please wait 24 hours.");
         vm.prank(owner);
         faucet.withdraw(user1);
 
-        // // Fast forward time by 24 hours
+        // Fast forward time by 24 hours
         vm.warp(block.timestamp + 1 days);
 
-        // // Should work now
+        // Should work now
         vm.prank(owner);
         faucet.withdraw(user1);
         assertEq(user1.balance, tokenAmount * 2);