Mingw cross master #645

clanmills · 2019-01-09T15:46:13Z

No description provided.

src/futils.cpp

D4N

You have put 3 quite large binary files into the repo, but these are distributed files from mingw, they imho don't belong into the git repo. I would suggest to fetch these in a script or advise the user where they can download them.

clanmills · 2019-01-09T16:53:18Z

You're right. I shouldn't have done that.

I did this because I was exhausted with Gilles/MXE bullshit and didn't have the energy to solve the puzzle of how to get them an easier way. Gilles/MXE stuff was building for 24 hours. Having put them in the bundle, I stopped thinking about them.

However, you're right. I should document how to get them and that will resolve how to obtain the 32 bit DLLs. I'll investigate/fix that tomorrow.

I tried to fix the typo concerning MSC_VER in the branch mingw-cross-master. Git refuses to allow me to submit that change.

codecov · 2019-01-27T15:29:11Z

Codecov Report

Merging #645 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   62.24%   62.24%           
=======================================
  Files         154      154           
  Lines       21234    21234           
=======================================
  Hits        13218    13218           
  Misses       8016     8016

Impacted Files	Coverage Δ
src/futils.cpp	`86.88% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6332a...e89bfe6. Read the comment docs.

kamgha · 2019-02-06T17:46:52Z

You have put 3 quite large binary files into the repo, but these are distributed files from mingw, they imho don't belong into the git repo. I would suggest to fetch these in a script or advise the user where they can download them.

Hi, I'd suggest to compile in the depedencies statically into the resulting binaries, e. g. through -static or -lstdc++ -lgcc or -static-libstdc++ -static-libgcc.

clanmills · 2019-02-06T20:26:09Z

Yes. This is a good idea. I'm on vacation in Florida at the moment. We're planning a "dot" release of Exiv2 v0.27.1 to be released at the end of March. I'll work on this when I get home.

This will be the first release of Exiv2 in which we support/document cross compiling. It's a good idea to support both static and dynamic linking.

D4N · 2019-02-06T22:18:52Z

Hi, I'd suggest to compile in the depedencies statically into the resulting binaries, e. g. through -static or -lstdc++ -lgcc or -static-libstdc++ -static-libgcc.

As @clanmills said: the plan is to support dynamic and static linking. My complaint was only concerning the addition of these libraries into the git repository.

@clanmills I modified the commits about a week ago and dropped these binaries.

piponazo · 2019-02-07T06:13:34Z

I did not review yet the code because I see there are some conflicts. I'll review it once the branch is in a "clean" state

# Conflicts: # README.md

…atrix

piponazo · 2019-02-10T09:06:25Z

It seems we have some warnings (treated as errors on windows):

/Fdsrc\CMakeFiles\exiv2lib.dir\exiv2lib.pdb /FS -c ..\src\basicio.cpp
..\src\basicio.cpp(246): error C2220: warning treated as error - no 'object' file generated
..\src\basicio.cpp(246): warning C4244: '=': conversion from '__int64' to 'off_t', possible loss of data
[43/182] Building CXX object src\CMakeFiles\exiv2lib.dir\bmpimage.cpp.obj
[44/182] Building CXX object src\CMakeFiles\exiv2lib.dir\bigtiffimage.cpp.obj

Plus other things:

..\src\image.cpp(881): fatal error C1017: invalid integer constant expression

D4N · 2019-02-10T09:10:47Z

I just dropped the commit that enabled wchar_t on Windows, so they'll go away. We should enable that for #685, but not in this PR.

piponazo · 2019-02-10T09:04:32Z

README-CONAN.md

@@ -610,4 +618,4 @@ $ cmake -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_CURL=ON -DEXIV2_ENABLE_SSH=ON

 [TOC](#TOC)

-Written by Robin Mills<br>[email protected]<br>Updated: 2018-11-22
+Written by Robin Mills<br>[email protected]<br>Updated: 2018-01-09


I guess you want to update also the year 😉

piponazo · 2019-02-10T09:31:36Z

contrib/mingw-cross/build.sh

+-DCMAKE_BUILD_TYPE=Release"
+
+
+ZLIB=$( realpath ${PWD}/../../../zlib-1.2.11)


There is something I do not understand about the zlb and expat dependencies. There is one point in which you mentioned that those are handled by conan, and afterwards I understood that we need to compile them by hand?

Are not these libraries handled by conan properly ?

In fact, I see that you are installing the package mingw64-zlib in that fedora image.

The Fedora build does not use this script.

I am not sure if we even should include it at all? It builds a lot of dependencies manually, which is imho not the way to go. We can pull in the mingw dependencies via dnf or apt on Fedora, Debian and Ubuntu. Or probably via Conan on the other platforms.

For the Linux distributions we are testing with Gitlab it makes more sense to use the system packages if possible, so that we really tests if those distributions can use Exiv2 without caring much about external dependencies.

Maybe for cross-compiling, it is more difficult to find the system packages ... and we could end up compiling something via a script or conan.

The main aim of my comment was to highlight the contradiction in the documentation.

piponazo · 2019-02-10T09:32:30Z

contrib/mingw-cross/conan-build.sh

+cp       ../gcc64/*.dll     bin/
+wine     bin/exiv2 -vV
+
+# That's all Folks!


🤣 do you also love that file ending?

piponazo · 2019-02-10T09:33:10Z

src/futils.cpp

-        const size_t idxLastSeparator = ret.find_last_of('/');
-    #endif
+
+        const size_t idxLastSeparator = ret.find_last_of(EXV_SEPARATOR_STR);


D4N · 2019-03-21T22:11:32Z

@clanmills do you want to pursue this PR further and add the script for MXE building to the repo?

clanmills · 2019-03-25T10:22:36Z

I believe you and Luis have put in a lot of effort into this topic and I'm happy to close this. I hope we'll get the new hosting for exiv2.org working this week and I'll release v0.27.1 RC1. I intend to add notes to README-CONAN.md about cross-compiling. I hope it only involves copy/merging from master.

clanmills requested a review from piponazo January 9, 2019 15:46

D4N reviewed Jan 9, 2019

View reviewed changes

src/futils.cpp Outdated Show resolved Hide resolved

D4N requested changes Jan 9, 2019

View reviewed changes

D4N mentioned this pull request Jan 23, 2019

MinGW cross compilation support #663

Closed

4 tasks

D4N force-pushed the mingw-cross-master branch from e08b20a to 91703b1 Compare January 27, 2019 15:29

D4N force-pushed the mingw-cross-master branch from 91703b1 to 244418a Compare January 27, 2019 16:00

D4N mentioned this pull request Feb 6, 2019

[WIP] Fix the Error type #685

Closed

clanmills and others added 3 commits February 9, 2019 11:17

Fix #610 WIP. TODO: Documentation. Test: MinGW/msys2, Cygwin, msvc.

460c25e

Documentation update for mingw-cross

9c9269d

# Conflicts: # README.md

[ci] Refactor ci/test_build.py to allow customizations of the build m…

cbf787b

…atrix

D4N force-pushed the mingw-cross-master branch from 244418a to 0b5388f Compare February 9, 2019 10:25

[ci] Add Fedora cross compilation build job with MinGW

e89bfe6

D4N force-pushed the mingw-cross-master branch from 623f207 to e89bfe6 Compare February 10, 2019 09:08

piponazo approved these changes Feb 10, 2019

View reviewed changes

piponazo mentioned this pull request Feb 27, 2019

Fix #610 #720

Closed

D4N mentioned this pull request Feb 27, 2019

Add MinGW build to GitLab CI #721

Merged

D4N closed this Mar 25, 2019

clanmills deleted the mingw-cross-master branch April 28, 2020 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mingw cross master #645

Mingw cross master #645

clanmills commented Jan 9, 2019

D4N left a comment

clanmills commented Jan 9, 2019

codecov bot commented Jan 27, 2019 •

edited

Loading

kamgha commented Feb 6, 2019

clanmills commented Feb 6, 2019

D4N commented Feb 6, 2019

piponazo commented Feb 7, 2019

piponazo commented Feb 10, 2019 •

edited

Loading

D4N commented Feb 10, 2019

piponazo Feb 10, 2019

piponazo Feb 10, 2019

piponazo Feb 10, 2019

D4N Feb 11, 2019

piponazo Feb 11, 2019

piponazo Feb 10, 2019

piponazo Feb 10, 2019

D4N commented Mar 21, 2019

clanmills commented Mar 25, 2019

		-DCMAKE_BUILD_TYPE=Release"


		ZLIB=$( realpath ${PWD}/../../../zlib-1.2.11)

Mingw cross master #645

Mingw cross master #645

Conversation

clanmills commented Jan 9, 2019

D4N left a comment

Choose a reason for hiding this comment

clanmills commented Jan 9, 2019

codecov bot commented Jan 27, 2019 • edited Loading

Codecov Report

kamgha commented Feb 6, 2019

clanmills commented Feb 6, 2019

D4N commented Feb 6, 2019

piponazo commented Feb 7, 2019

piponazo commented Feb 10, 2019 • edited Loading

D4N commented Feb 10, 2019

piponazo Feb 10, 2019

Choose a reason for hiding this comment

piponazo Feb 10, 2019

Choose a reason for hiding this comment

piponazo Feb 10, 2019

Choose a reason for hiding this comment

D4N Feb 11, 2019

Choose a reason for hiding this comment

piponazo Feb 11, 2019

Choose a reason for hiding this comment

piponazo Feb 10, 2019

Choose a reason for hiding this comment

piponazo Feb 10, 2019

Choose a reason for hiding this comment

D4N commented Mar 21, 2019

clanmills commented Mar 25, 2019

codecov bot commented Jan 27, 2019 •

edited

Loading

piponazo commented Feb 10, 2019 •

edited

Loading