base64decode should return immediately if the input is empty #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
approved these changes
Nov 11, 2024
neheb
approved these changes
Nov 11, 2024
|
Do we need to backport this to 0.28.x? |
Good idea. I don't think we need to do a new release for it though. |
|
https://github.com/Mergifyio backport 0.28.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some minor issues found by https://github.com/google/oss-fuzz-gen. They're using an AI system to generate new fuzz targets that test internal functions. In this case, they're fuzzing
base64decodeandUri::Parse. I'll fix these issues, but I'm worried that this is going to turn into a massive spam problem, because it's easy to find crashes if you call internal functions with invalid arguments.